Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix google.api.http URLs with proper hierarchy #188

Open
glimchb opened this issue Nov 3, 2022 · 3 comments
Open

fix google.api.http URLs with proper hierarchy #188

glimchb opened this issue Nov 3, 2022 · 3 comments
Assignees
@jainvipin
Labels
good first issue Good for newcomers Storage APIs or code related to storage area

Comments

@glimchb
Copy link
Member

glimchb commented Nov 3, 2022 •
edited
Loading

see #186 (comment)
see #186 (comment)

we might want to prefix the path with nvme, virtio, etc. i.e. instead of implicit assumptions we can keep the nvme path to /v1/nvme/subsystems, /v1/nvme/controllers, etc.
or i.e. /v1/nvme/frontend/subsystems or /v1/nvme/fe/subsystems vs. /v1/nvme/subsystems

also relationship between subsystems and controllers something like: post: "/v1/subsystems/{subsystem}/controllers"
@glimchb glimchb added good first issue Good for newcomers Storage APIs or code related to storage area labels Nov 3, 2022
@glimchb glimchb mentioned this issue Nov 3, 2022
Merged
@glimchb glimchb changed the title backlog: re-check google.api.http URLs fix google.api.http URLs with proper hierarchy Nov 4, 2022
This was referenced Nov 14, 2022
Merged
Merged
@jainvipin
Copy link
Contributor

Recommend:
Nvme: /v1alpha/nvme/frontend/...
iSCSI: /v1alpha/iscsi/frontend/...
Virtio: /v1alpha/virtio/frontend/...
Middleend: /v1alpha/middleend/...

happy to submit a PR if we agree.

@glimchb
Copy link
Member Author

glimchb commented Nov 16, 2022

not frontend before the protocol ?

This was referenced Dec 6, 2022
Merged
Merged
@glimchb
Copy link
Member Author

glimchb commented Jun 5, 2023

also see https://google.aip.dev/122#resource-uris

//calendar.googleapis.com/users/vhugo1802
vs
https://calendar.googleapis.com/v3/users/vhugo1802

@artek-koltun artek-koltun mentioned this issue Jul 4, 2023
Closed
This was referenced Sep 7, 2023
Closed
Open
@artek-koltun artek-koltun mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainvipin jainvipin

Labels
good first issue Good for newcomers Storage APIs or code related to storage area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jainvipin @glimchb