[storage] Add target to virtio-scsi, clean up virtio-blk #207
Conversation
Signed-off-by: Ben Walker <[email protected]>
glimchb
added
Storage
glimchb
requested review from
jainvipin,
llabordehpe,
mkalderon,
orendu,
a team and
PWAlessi
|
@benlwalker you can add |
| service FrontendVirtioScsiService { | ||
| rpc CreateVirtioScsiTarget (CreateVirtioScsiTargetRequest) returns (VirtioScsiTarget) { | ||
| option (google.api.http) = { | ||
| post: "/v1/virtioscsitargets" |
There was a problem hiding this comment.
URLs needs hierarchy - hopefully we can do it after this PR; the flattened url names are including the hierarchy in the names explicitly. So the URLs in this and in NVMe protos can be done separately.
There was a problem hiding this comment.
I opened #188 to track the fix of all the URLs at once
|
|
||
| message VirtioScsiTargetStatsResponse { | ||
| common.v1.ObjectKey id = 1; | ||
| string stats = 2; |
There was a problem hiding this comment.
not sure if this makes any sense, returning a big string for stats; if we are unsure about stats protos, we can remove it from here and introduce if with a bit more structure/thinking later. I'd suggest removing statis req/response all together for now.
There was a problem hiding this comment.
we have now string stats defined in all our objects, so I'm personally OK with this now to align with what we have already and then fix stats later on. opened #209 to track
virtio-scsi has the same 3 level object system as NVMe
Signed-off-by: Ben Walker [email protected]