[storage] [backend] Add Handle to BE object now #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to opiproject#174 Resource-oriented design https://google.aip.dev/121 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added
Storage
glimchb
requested review from
benlwalker,
GottliebNoam,
intelfisz,
jainvipin,
llabordehpe,
mkalderon and
orendu
mkalderon
approved these changes
Dec 6, 2022
| @@ -39,49 +44,37 @@ message NVMfRemoteControllerConnectRequest { | |||
| NVMfRemoteController ctrl = 1; | |||
There was a problem hiding this comment.
why not provide the objectKey here ?
There was a problem hiding this comment.
good question. according to what we did in frontend, we put the ID inside the object, so I wanted to align those here as well. From https://google.aip.dev/133#user-specified-ids indeed IDs should be in the request message, not the object and named string {resource}_id
| } | ||
|
|
||
| message NVMfRemoteControllerListRequest { | ||
| int64 id = 1; | ||
| int32 page_size = 1; | ||
| string page_token = 2; | ||
| } |
There was a problem hiding this comment.
how are these related to this pr ?
There was a problem hiding this comment.
I could've split in 2 commits here, you are right.
the page fields are from https://google.aip.dev/132
just aligning the objects here from the frontend work we did
|
we could go with using keys/handles and status/spec on backend objects as well. |
yes, good idea |
See opiproject#174 Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done Signed-off-by: Boris Glimcher <[email protected]>
glimchb
commented
Dec 6, 2022
| rpc AioControllerUpdate (AioControllerUpdateRequest) returns (AioController) {} | ||
| rpc CreateAioController (CreateAioControllerRequest) returns (AioController) { | ||
| option (google.api.http) = { | ||
| post: "/v1/subsystems" |
| rpc NullDebugGet (NullDebugGetRequest) returns (NullDebug) {} | ||
| rpc CreateNullDebug (CreateNullDebugRequest) returns (NullDebug) { | ||
| option (google.api.http) = { | ||
| post: "/v1/subsystems" |
| rpc NVMfRemoteControllerGet (NVMfRemoteControllerGetRequest) returns (NVMfRemoteControllerGetResponse) {} | ||
| rpc CreateNVMfRemoteController (CreateNVMfRemoteControllerRequest) returns (NVMfRemoteController) { | ||
| option (google.api.http) = { | ||
| post: "/v1/subsystems" |
sandersms
approved these changes
Dec 7, 2022
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Dec 7, 2022
Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done See opiproject/opi-api#217 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Dec 7, 2022
Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done See opiproject/opi-api#217 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Dec 7, 2022
Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done See opiproject/opi-api#217 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to glimchb/opi-spdk-bridge
that referenced
this pull request
Dec 7, 2022
Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done See opiproject/opi-api#217 Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added a commit
to opiproject/opi-spdk-bridge
that referenced
this pull request
Dec 7, 2022
Resource-oriented design https://google.aip.dev/121 for word in Get List Create Update Delete; do for i in AioController NullDebug NVMfRemoteController; do sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ; done; done See opiproject/opi-api#217 Signed-off-by: Boris Glimcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #174
Resource-oriented design https://google.aip.dev/121
Signed-off-by: Boris Glimcher [email protected]