Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto file define the same http annotation with different rpc method #303

Closed
devkevinyy opened this issue Jun 27, 2023 · 5 comments · Fixed by #333
Closed

proto file define the same http annotation with different rpc method #303

devkevinyy opened this issue Jun 27, 2023 · 5 comments · Fixed by #333
Labels
Storage APIs or code related to storage area

Comments

@devkevinyy
Copy link
Contributor

devkevinyy commented Jun 27, 2023

when i use grpc-gateway to proxy the storage gRPC service, i found the same http route in the .gw.pb files.

for example: storage/v1alpha1/frontend_nvme_pcie.proto

rpc ListNvmeSubsystems   (ListNvmeSubsystemsRequest)   returns (ListNvmeSubsystemsResponse)   {
      option (google.api.http) = {
          get: "/v1/{parent=subsystems}"
      };
      option (google.api.method_signature) = "parent";
  }

and

rpc ListNvmeControllers   (ListNvmeControllersRequest)   returns (ListNvmeControllersResponse)   {
      option (google.api.http) = {
          get: "/v1/{parent=subsystems}"
      };
      option (google.api.method_signature) = "parent";
}

above two different rpc method: ListNvmeSubsystems、ListNvmeControllers has the same http anotation url.

@artek-koltun
Copy link
Contributor

Duplicates/relates to #188 ?

@artek-koltun artek-koltun added the Storage APIs or code related to storage area label Jul 4, 2023
@devkevinyy
Copy link
Contributor Author

devkevinyy commented Jul 5, 2023

not the same, but the issue #188 can also resolve the problem after redefine the rpc methods http anotations according to business rules.

@glimchb
Copy link
Member

glimchb commented Aug 14, 2023

@chujieyang some was fixed by #317
can you propose a fix for the rest, please ?

@devkevinyy
Copy link
Contributor Author

I hava submit a pull request with the http anotations. #331

@glimchb
Copy link
Member

glimchb commented Aug 25, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage APIs or code related to storage area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants