feat(storage): modify storage frontend_nvme_pcie proto file to support http api #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gen/grpc-gateway/gen/github.com/opiproject/opi-api/storage/v1alpha1/gen/go/backend_aio.pb.go
Outdated
Show resolved
Hide resolved
devkevinyy
force-pushed
the
storage-proto-http
branch
from
1f8cdce to
8138907
Compare
devkevinyy
force-pushed
the
storage-proto-http
branch
from
3995107 to
42e6516
Compare
glimchb
reviewed
Aug 28, 2023
|
@chujieyang please rebase so we can review it again and run through ci |
devkevinyy
force-pushed
the
storage-proto-http
branch
2 times, most recently
from
5411636 to
a82e696
Compare
done |
artek-koltun
reviewed
Sep 1, 2023
devkevinyy
force-pushed
the
storage-proto-http
branch
from
a82e696 to
956dd5e
Compare
glimchb
reviewed
Sep 5, 2023
glimchb
requested changes
Sep 5, 2023
glimchb
reviewed
Sep 6, 2023
There was a problem hiding this comment.
@artek-koltun I'm ok with this change, please review as well before we merging it
glimchb
added
the
Merge Candidate
glimchb
approved these changes
Sep 6, 2023
glimchb
requested review from
jainvipin,
benlwalker,
GottliebNoam and
sburla-marvell
artek-koltun
approved these changes
Sep 18, 2023
|
@chujieyang please rebase |
…t http api Signed-off-by: yangchujie <[email protected]>
Signed-off-by: yangchujie <[email protected]>
Signed-off-by: yangchujie <[email protected]>
devkevinyy
force-pushed
the
storage-proto-http
branch
from
956dd5e to
91f9250
Compare
Done. |
|
@chujieyang please check the opiproject/godpu#306 that fixes this change API in our client code you already have draft opened for opiproject/opi-spdk-bridge#610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the google.api.http definition in the frontend_nvme_pcie proto file in the storage module to better support converting proto to grpc gateway http service