Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R packages crew and crew.cluster, along with prerequisites. From conda_r_skeleton_helper #24498

Merged
merged 13 commits into from
Feb 23, 2024

Conversation

brendanf
Copy link
Contributor

@brendanf brendanf commented Nov 14, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crew, recipes/r-crew.cluster, recipes/r-getip, recipes/r-mirai, recipes/r-nanonext) and found it was in an excellent condition.

@mfansler mfansler added the R label Nov 16, 2023
@brendanf
Copy link
Contributor Author

@conda-forge/help-r
The Windows error is
ERROR (r-getip,lib/R/library/getip/libs/x64/getip.dll): $RPATH/R.dll not found in packages, sysroot(s) nor the missing_dso_whitelist. .. is this binary repackaging?.

I'm far from an expert on getting things to build in Windows. I would expect that R.dll should be packaged by r-base, but it somehow isn't being found in this check (although the actual R CMD install seems to have worked fine). I can't see that getip is doing anything unconventional with library paths. Anyone have any advice?

@dbast
Copy link
Member

dbast commented Jan 11, 2024

@brendanf Can you please split this PR into multiple PRs to review? maybe one PR with all noarch recipes and then individual ones for the compiled recipes.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crew, recipes/r-crew.cluster, recipes/r-mirai) and found some lint.

Here's what I've got...

For recipes/r-crew:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-crew.cluster:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

For recipes/r-mirai:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a minor touch up, and we need to wait for r-getip and r-nanonext to get generated.

recipes/r-mirai/meta.yaml Outdated Show resolved Hide resolved
- "\"%R%\" -e \"library('crew')\"" # [win]

about:
home: https://wlandau.github.io/crew/, https://github.com/wlandau/crew
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split urls

Suggested change
home: https://wlandau.github.io/crew/, https://github.com/wlandau/crew
home: https://wlandau.github.io/crew/
dev_url: https://github.com/wlandau/crew

recipes/r-crew.cluster/meta.yaml Outdated Show resolved Hide resolved
brendanf and others added 2 commits February 3, 2024 10:29
Co-authored-by: Mervin Fansler <[email protected]>
Co-authored-by: Mervin Fansler <[email protected]>
@brendanf
Copy link
Contributor Author

@conda-forge-admin, please restart ci

@brendanf
Copy link
Contributor Author

@conda-forge/help-r Now that the prerequisites are available, this builds on Linux and OSX. Windows is failing due to #25319

@brendanf brendanf requested a review from mfansler February 18, 2024 11:32
@mfansler mfansler merged commit 7e42df0 into conda-forge:main Feb 23, 2024
2 of 5 checks passed
@mfansler
Copy link
Member

mfansler commented Feb 23, 2024

Thanks for adding these! ❤️

Note that since these have interdependencies (crew.cluster -> crew -> mirai), the CI on the feedstocks will likely fail in the first round and require manual restarts. I'll try to keep an eye out, but you can view the CI jobs by clicking the indicator (red "X" or green check) next to commit on the feedstock pages. Options to "Re-run" failed jobs should be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants