Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conda_r_skeleton_helper recipes for crew.cluster and prerequisites #22883

Closed
wants to merge 6 commits into from

Conversation

brendanf
Copy link
Contributor

@brendanf brendanf commented May 23, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crew, recipes/r-crew.cluster, recipes/r-getip, recipes/r-mirai, recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-getip:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/r-getip:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [48].
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/r-mirai:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/r-nanonext:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • requirements: build: mbedtls >= 2 should not contain a space between relational operator and the version, i.e. mbedtls >=2
  • requirements: build: nng >= 1.6.0 should not contain a space between relational operator and the version, i.e. nng >=1.6.0
  • requirements: run: mbedtls >= 2 should not contain a space between relational operator and the version, i.e. mbedtls >=2
  • requirements: run: nng >= 1.6.0 should not contain a space between relational operator and the version, i.e. nng >=1.6.0

For recipes/r-nanonext:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [52].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crew, recipes/r-crew.cluster, recipes/r-getip, recipes/r-mirai, recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-getip:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/r-mirai:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/r-nanonext:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crew, recipes/r-crew.cluster, recipes/r-getip, recipes/r-mirai, recipes/r-nanonext) and found it was in an excellent condition.

@brendanf
Copy link
Contributor Author

oops, accidentally duplicated this in #24498

@brendanf brendanf closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant