Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-nanonext from conda_r_skeleton_helper #25208

Merged
merged 36 commits into from
Feb 18, 2024
Merged

Conversation

brendanf
Copy link
Contributor

@brendanf brendanf commented Feb 2, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-nanonext:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@brendanf
Copy link
Contributor Author

brendanf commented Feb 2, 2024

Split from #24498

@brendanf
Copy link
Contributor Author

brendanf commented Feb 3, 2024

The current build of nng is using mbedtls 3.3.0, which has a different ABI than mbedtls 3.5.1, which is the first conda--forge build which supports Windows. I have put in a PR to pin nng to mbedtls 3.5.1, and also including mbedtls support on Windows. Hopefully that will allow a successful build here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-nanonext:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [42, 46, 47]
  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-nanonext:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [43, 47, 48]
  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-nanonext) and found some lint.

Here's what I've got...

For recipes/r-nanonext:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@brendanf
Copy link
Contributor Author

@conda-forge/r I think this is finally ready for review. The build worked on Windows for R 4.1, but if I understand correctly the 4.2 build will need to use UCRT and that may need some extra adaptation.

@brendanf
Copy link
Contributor Author

Actually, to get tagged for review maybe I need to ping @conda-forge/help-r ?

@dbast dbast merged commit 8d8797e into conda-forge:main Feb 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants