Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): use config:recommended for renovate #1462

Merged
merged 5 commits into from
Apr 26, 2024
Merged

feat(tools): use config:recommended for renovate #1462

merged 5 commits into from
Apr 26, 2024

Conversation

rubiesonthesky
Copy link
Contributor

PR Checklist

Overview

Using config:recommended for renovate config. config:best-practices looked too opinionated for common user, so I think this recommended is better fit. I also added maintainLockFilesWeekly and replacements:all. I'm not sure if maintainLockFilesWeekly is needed when there is pnpm dedupe in every PR already.

BTW, some tools seems to be fighting over formatting in this repo. When I save this file in VS code it's formatted differently than what is seen in this PR. So when you stage / commit the file, it gets different formatting.

(I re-created this PR because I just learned that using this branch name, you will get renovate validation for free https://docs.renovatebot.com/config-validation/ )

@rubiesonthesky rubiesonthesky mentioned this pull request Apr 11, 2024
Merged
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg requested changes Apr 13, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for getting this started! A couple of questions/changes I'm not super confident on. 🧹

.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Apr 13, 2024
@JoshuaKGoldberg
Copy link
Owner

BTW, some tools seems to be fighting over formatting in this repo. When I save this file in VS code it's formatted differently than what is seen in this PR. So when you stage / commit the file, it gets different formatting.

Huh. I don't get that locally. If you can reproduce that might be a separate issue?

@rubiesonthesky @JoshuaKGoldberg
Apply suggestions from code review
3c367ad 
Co-authored-by: Josh Goldberg ✨ <[email protected]>
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Apr 13, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks, this is great!

I'm particularly excited to have the recommended replacements automated for the repos. 😄

JoshuaKGoldberg
JoshuaKGoldberg requested changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost!

.github/renovate.json Outdated Show resolved Hide resolved
.github/renovate.json Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Apr 24, 2024
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Apr 24, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit ebdf841 into JoshuaKGoldberg:main Apr 26, 2024
13 of 14 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @rubiesonthesky for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Apr 26, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @rubiesonthesky! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this pull request Apr 26, 2024
@allcontributors
docs: add rubiesonthesky as a contributor for code (#1473)
61e24a8 
Adds @rubiesonthesky as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#1462 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.59.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/TypeStat that referenced this pull request Dec 1, 2024
@rubiesonthesky
chore: use config:recommended for renovate (#1564)
054fe66 
## PR Checklist

- [ ] Addresses an existing open issue: fixes #000
- [ ] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/TypeStat/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/TypeStat/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Same as here:
JoshuaKGoldberg/create-typescript-app#1462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Renovate config use preset config:recommended or config:best-practices
2 participants
@rubiesonthesky @JoshuaKGoldberg