Skip to content

Commit

Permalink
feat(tools): use config:recommended for renovate (#1462)
Browse files Browse the repository at this point in the history
## PR Checklist

- [x] Addresses an existing open issue: fixes #1455
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Using `config:recommended` for renovate config. `config:best-practices`
looked too opinionated for common user, so I think this recommended is
better fit. I also added `maintainLockFilesWeekly` and
`replacements:all`. I'm not sure if `maintainLockFilesWeekly` is needed
when there is pnpm dedupe in every PR already.

- maintainLockFilesWeekly: "Run lock file maintenance (updates) early
Monday mornings."
https://docs.renovatebot.com/presets-default/#maintainlockfilesweekly
- replacementsall: "Apply crowd-sourced package replacement rules."
https://docs.renovatebot.com/presets-replacements/#replacementsall

BTW, some tools seems to be fighting over formatting in this repo. When
I save this file in VS code it's formatted differently than what is seen
in this PR. So when you stage / commit the file, it gets different
formatting.

(I re-created this PR because I just learned that using this branch
name, you will get renovate validation for free
https://docs.renovatebot.com/config-validation/ )

---------

Co-authored-by: Josh Goldberg ✨ <[email protected]>
  • Loading branch information
rubiesonthesky and JoshuaKGoldberg authored Apr 26, 2024
1 parent d2f7271 commit ebdf841
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/renovate.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"automerge": true,
"extends": ["config:best-practices", "replacements:all"],
"ignoreDeps": ["codecov/codecov-action"],
"internalChecksFilter": "strict",
"labels": ["dependencies"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ We appreciate your efforts and responsible disclosure and will make every effort
"renovate.json": await formatJson({
$schema: "https://docs.renovatebot.com/renovate-schema.json",
automerge: true,
extends: ["config:best-practices", "replacements:all"],
ignoreDeps: ["codecov/codecov-action"],
internalChecksFilter: "strict",
labels: ["dependencies"],
Expand Down

0 comments on commit ebdf841

Please sign in to comment.