Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use config:recommended for renovate #1564

Merged

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

Same as here: JoshuaKGoldberg/create-typescript-app#1462

@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved 🙅 label Apr 13, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(marking as blocked on discussion in #1462)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 13, 2024 14:34
@rubiesonthesky
Copy link
Collaborator Author

This now uses same config as create-typescript-app, see JoshuaKGoldberg/create-typescript-app#1462

@rubiesonthesky rubiesonthesky marked this pull request as ready for review May 4, 2024 17:21
@rubiesonthesky rubiesonthesky removed the status: blocked Waiting for something else to be resolved 🙅 label May 4, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Btw @rubiesonthesky if I ever take more than a few weeks to get respond on a PR, it's definitely some combination of forgetting and/or procrastinating. If you ping me I'll apologize and come back to it. Sorry for taking so long on this one!

(especially a straightforward one like this)

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(tools): use config:recommended for renovate chore: use config:recommended for renovate Dec 1, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 054fe66 into JoshuaKGoldberg:main Dec 1, 2024
11 checks passed
Copy link

github-actions bot commented Dec 2, 2024

🎉 This is included in version v0.8.4 🎉

The release is available on:

Cheers! 📦🚀

@rubiesonthesky
Copy link
Collaborator Author

@JoshuaKGoldberg I think at the time we discussed on discord / github, that you were super busy. So it was expected that you wouldn't have time to check these things :)

@rubiesonthesky rubiesonthesky deleted the renovate/reconfigure branch December 6, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants