Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SwerveKinematics.toChassisSpeeds overload method signature to match its superclass. #7519

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

falOn-Dev
Copy link
Contributor

The SwerveKinematics override of toChassisSpeeds() was set up to use a vararg rather than an array like the Kinematics.toChassisSpeeds() signature. This PR fixes the override to match its superclass.

@falOn-Dev falOn-Dev requested a review from a team as a code owner December 8, 2024 04:33
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on conversation in the Discord server, this was done due to IntelliJ intellisense in a Kotlin project having trouble resolving the imports (even though it still compiles). However, this change breaks everything passing the swerve module states individually, as evidenced by the CI failures. I'm hesitant about making a breaking change that will affect many teams to improve intellisense on an IDE that is not primarily supported on a language that is not primarily supported. (Though if the problem turns out to affect VSCode and/or Java as well, that would change things)
That said, I'm not the person to make the final call here.

Also, if we do want to do this, we should remove the @SuppressWarnings("overrides") at the top of the class which is no longer necessary.

@falOn-Dev
Copy link
Contributor Author

I do not feel insanely strongly about this PR as i've determined it's merely a visual issue in IntelliJ with kotlin, it compiles fine and works fine, I only left it open out of a personal distaste for mismatched overrides

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants