Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature -> Develop | Added Datadog for Error monitoring and Logging #47

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Feature -> Develop | Added Datadog for Error monitoring and Logging #47

wants to merge 18 commits into from

Conversation

we-meetkumar-s001
Copy link
Collaborator

@we-meetkumar-s001 we-meetkumar-s001 commented Nov 15, 2024 •
edited
Loading

Task #10861 > VaahFlutter > Error monitoring and Logging > Add DataDog Support

Time invested: hh:mm format | Billable: 30:00 | Non-Billable: 00:00

Problem Statement

  1. DataDog support was not available, implemented that.

Describe The Fix/ Solution You Implemented

Added 2 plugins for this implementation, using those created one service DataDogLoggingService . To use this we just need to add required configuration like clientId, bundleIdOfApp, applicationId into env variable and then we can use this feature.

Proof of your testing (Demo link or video links or image links)

Dependencies

  • Updated: None
  • Added:
    • datadog_flutter_plugin: ^2.8.0
    • datadog_tracking_http_client: ^2.2.0

Merge Request Checklist

  • I have performed a self-review of my code
  • My code does follow industry standards
  • My code doesn't produce warnings/ errors for dart analyzer
  • New and existing tests pass locally with my changes (No tests are there as of now)
  • The code modified as part of this PR has been covered with tests
  • My code is properly formatted
  • I've followed the proper naming conventions
  • I have rebased the feature on the latest develop
  • I have run flutter run after the rebase
  • I have added new dependencies/ updated old dependencies
  • I have read all the comments & notes in wireframe and verified that I did take care of that
  • verify that the UI must match with design & wireframe if available
  • I have updated the version/ build (x.x.x+xxx)
  • I've verified that the latest commit of develop exists in your feature branch after rebase.
  • My fix achieves 100% of what is required
  • Can enhance the solution in the future because better implementation could be made

@we-meetkumar-s001 we-meetkumar-s001 added the enhancement New feature or request label Nov 15, 2024
we-prajapati-c001
we-prajapati-c001 requested changes Nov 18, 2024
View reviewed changes
ios/Runner.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
lib/app_config.dart Outdated Show resolved Hide resolved
lib/app_config.dart Outdated Show resolved Hide resolved
lib/vaahextendflutter/base/base_controller.dart Outdated Show resolved Hide resolved
lib/vaahextendflutter/services/logging_library/_cloud/datadog_logging_service.dart Outdated Show resolved Hide resolved
lib/views/pages/home.dart Outdated Show resolved Hide resolved
@we-prajapati-c001
Copy link
Collaborator

To fix the imports issue easily, use this extension in Visual Studio Code, press command + shift + p and type Fix All Imports and select that

we-prajapati-c001
we-prajapati-c001 reviewed Nov 20, 2024
View reviewed changes
lib/vaahextendflutter/base/base_controller.dart Outdated Show resolved Hide resolved
lib/views/pages/home.dart Outdated Show resolved Hide resolved
@we-meetkumar-s001
Copy link
Collaborator Author

@we-prajapati-c001 Changed are done, re validate all.

@we-prajapati-c001
Copy link
Collaborator

Reviewed gave few minor suggestions, everything else LGTM

@we-prajapati-c001 we-prajapati-c001 self-requested a review November 22, 2024 05:54
@we-meetkumar-s001
Updated: refactor logging service file
79e0785 
- View added for errorType and datadog in debug sheet
- Added console log for unimplemented methods for services
- Moved ErrorType enum to env
- Extend to implements for firebase service
- Removed condition for firebase init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@we-prajapati-c001 we-prajapati-c001 we-prajapati-c001 approved these changes

@themodernpk themodernpk Awaiting requested review from themodernpk

Assignees
No one assigned
Labels
enhancement New feature or request Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@we-meetkumar-s001 @we-prajapati-c001