Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/gitlab-packages): prefer checking for conan_package_name if it exists #33099

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+46 −1
Open

fix(datasource/gitlab-packages): prefer checking for conan_package_name if it exists #33099

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6036f5
fix(datasource/gitlab-packages): prefer checking for conan_package_na…
FFace32 Dec 13, 2024
0b07969
fix(datasource/gitlab-packages): fixed eslint error
FFace32 Dec 14, 2024
22e1327
test(datasource/gitlab-packages): added conan packages test
FFace32 Dec 14, 2024
f631bc4
test(datasource/gitlab-packages): reverted v prefix for some versions
FFace32 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/modules/datasource/gitlab-packages/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
result.releases = response
// Setting the package_name option when calling the GitLab API isn't enough to filter information about other packages
// because this option is only implemented on GitLab > 12.9 and it only does a fuzzy search.
.filter((r) => r.name === packagePart)
.filter((r) => (r.conan_package_name || r.name) === packagePart)

Check failure on line 83 in lib/modules/datasource/gitlab-packages/index.ts

View workflow job for this annotation

GitHub Actions / lint-eslint 

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
.map(({ version, created_at }) => ({
version,
releaseTimestamp: created_at,
Expand Down
1 change: 1 addition & 0 deletions lib/modules/datasource/gitlab-packages/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ export interface GitlabPackage {
version: string;
created_at: string;
name: string;
conan_package_name?: string;
}
Loading