fix(datasource/gitlab-packages): prefer checking for conan_package_name if it exists #33099
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checks if
conan_package_name
exists and matches the filtered package name for the gitlab-packages datasource.Context
When querying for uploaded Conan packages on GitLab, the
name
value contains the version and the channel as well, and this doesn't pass the filter inlib/modules/datasource/gitlab-packages/index.ts
.conan_package_name
, if it exists, contains only the package name.This can also be seen in the GitLab documentation as an example here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/packages.md?plain=1#L69-70
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: