Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config/presets): move parsePreset to avoid a circular dependency #33036

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Dec 11, 2024

Changes

Moves parsePreset from lib/config/presets/index.ts to lib/config/presets/parse.ts to avoid a circular dependency.

Context

#32688 (comment)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice December 11, 2024 10:28
@rarkins rarkins enabled auto-merge December 11, 2024 10:28
@rarkins rarkins added this pull request to the merge queue Dec 11, 2024
Merged via the queue into renovatebot:main with commit b094660 Dec 11, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.62.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@risu729 risu729 deleted the refactor/split-parse-preset branch December 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants