Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): add renovate config presets manager #32688

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Nov 23, 2024

Changes

Adds Renovate config presets manager.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@risu729
Copy link
Contributor Author

risu729 commented Nov 23, 2024

I'm not really sure about the code structure, but it seems I can't rely on config/presets/ in managers.
Should I rewrite the manager with regex?

@rarkins
Copy link
Collaborator

rarkins commented Dec 5, 2024

I'm not really sure about the code structure, but it seems I can't rely on config/presets/ in managers. Should I rewrite the manager with regex?

You can try refactoring the parsePreset(input: string): ParsedPreset function in lib/config/presets/index.ts to lib/config/presets/parse.ts as an effort to break the circulate dependency

@risu729
Copy link
Contributor Author

risu729 commented Dec 5, 2024

Thank you for your advice! I refactored and the circular dependencies were resolved.

@rarkins rarkins self-requested a review December 6, 2024 09:24
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a separate refactor PR to be merged first. 🤗

@risu729
Copy link
Contributor Author

risu729 commented Dec 11, 2024

please create a separate refactor PR to be merged first. 🤗

Sorry for refactoring in the same PR.
I opened #33036. Could you take a look when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Renovate Preset Config Manager
3 participants