Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dev dependencies to requirements-dev.txt (#61) #78

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

mehaase
Copy link
Contributor

@mehaase mehaase commented Nov 7, 2018

I used pip-tools to generate a requirements file. Also added a
Makefile to emulate how the requests package is laid out. Added
some documentation for using pip-tools. Finally, removed the
attrs dependency which wasn't really being used heavily enough
to justify its inclusion on this project.

I used pip-tools to generate a requirements file. Also added a
Makefile to emulate how the requests package is laid out. Added
some documentation for using pip-tools. Finally, removed the
attrs dependency which wasn't really being used heavily enough
to justify its inclusion on this project.
@mehaase mehaase requested a review from belm0 November 7, 2018 16:28
@mehaase
Copy link
Contributor Author

mehaase commented Nov 7, 2018

This isn't working as intended, yet. It is supposed to install trio-websocket in the development environment, so I put -e . in the dependencies file, but pip-compile expands this to a full path that only exists on my machine -e file:///Volumes/Case_Sensitive/trio-websocket. There's an issue filed on pip-tools but it looks like it's a complex interaction between pip and pip-tools that isn't likely to be solved anytime soon. I'll take another shot at this tomorrow.

@belm0
Copy link
Member

belm0 commented Nov 7, 2018

It's certainly possible to get by without using "-e .". Just prefix commands with appropriate setting of PYTHONPATH.

test:
	PYTHONPATH=. pytest --cov=trio_websocket

requirements-dev.txt Outdated Show resolved Hide resolved
requirements-dev.in Outdated Show resolved Hide resolved
Now `pip-compile` won't generate an absolute (and non-portable) path
in requirements-dev.txt. Since the trio-websocket package isn't
installed by pip tools anymore, I modified the Makefile to set the
PYTHONPATH. Added a note in the docs about setting PYTHONPATH in the
venv.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 81

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 91.644%

Totals Coverage Status
Change from base Build 71: 0.5%
Covered Lines: 340
Relevant Lines: 371

💛 - Coveralls

@mehaase mehaase merged commit e5360ae into master Nov 9, 2018
@mehaase mehaase deleted the move_dev_dependencies branch November 9, 2018 14:20
@mehaase
Copy link
Contributor Author

mehaase commented Nov 9, 2018

This still doesn't work for RTD builds. RTD does not use the Makefile, so it does not know where trio-websocket is. RTD can be configured to install from setup.py, but then it installs packages that conflict with requirements-dev.txt. I've pushed a quick fix on master that abandons pip tools and uses a hand-written requirements-dev.txt instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants