-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pipenv for development dependencies and running tests #61
Comments
The build fails because it can't find sphinxcontrib_trio, which is is a "dev" dependency. This quick fix is to make it a real dependency. This might be fixable by doing #61?
https://chriswarrick.com/blog/2018/07/17/pipenv-promises-a-lot-delivers-very-little/ virtualenvwrapper and pip-tools may be a better approach |
I am enjoying pipenv on the other project where I'm trying it out. The only gripe I have right now is that it can be pretty slow to lock packages. On the other hand, Read The Docs can only install from I don't know pip-tools yet, but that looks like a promising way forward. |
Re. Sphinx, how about keeping extras in requirements-extra.txt instead of setup.py? read docs must support it, e.g. trio does this. |
the sphinx issue is increasing our product dependencies by about 25%, I'd like to see that resolved |
I'm trying out pip-tools this morning. I like it, but its author recommends Pipenv instead:
But PyPA still recommends pip-tools as an alternative to Pipenv:
Anyway… I have a working setup that I will commit in a few minutes. |
I used pip-tools to generate a requirements file. Also added a Makefile to emulate how the requests package is laid out. Added some documentation for using pip-tools. Finally, removed the attrs dependency which wasn't really being used heavily enough to justify its inclusion on this project.
Move dev dependencies to requirements-dev.txt (#61)
Closed via #78. |
e.g. see Pipfile and Makefile in https://github.com/requests/requests
The text was updated successfully, but these errors were encountered: