-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action for release #36704
Github action for release #36704
Conversation
@@ -0,0 +1,63 @@ | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this script from pandas-release.
if we want to trigger actions probably better to have in same repo.
@@ -0,0 +1,51 @@ | |||
{% set version = environ.get("PANDAS_VERSION") %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from pandas-release and deleted the current recipe in pandas (may still want to retain existing though as builds from source instead of sdist)
version: {{ version }} | ||
|
||
source: | ||
url: ../dist/pandas-{{ version }}.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line changed otherwise copy and paste
"RLS: {}".format(tag[1:]), | ||
] | ||
) | ||
subprocess.check_call(["git", "tag", "-a", tag, "-m", "Version {}".format(tag[1:])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moreless copy and paste. deleted sync with upstream as working with origin
# push-tag: | ||
# description: 'Push tag on success?' | ||
# default: 'false' | ||
# required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once we have a tag we have a trigger for release
closing. wanted to avoid sharing credentials between repos just for tagging but going to continue using pandas-release for a bit. |
I've re-opened so we have somewhere to discuss implementation details. This is based off a workflow that I am using to test release readiness for the backport branch that I run manually. I think, since the backport branch doesn't have too many commits, could change this from a manual trigger to run on push to 1.1.x |
@simonjayhawkins move to pandas-release repo? |
probably need more discussion in #21050 before we can make progress here. closing to clear queue. |
for initial feedback. maybe way off base with this.
can be seen in action at https://github.com/simonjayhawkins/pandas/actions
the alternative of retaining a separate repo for release can be seen at https://github.com/simonjayhawkins/pandas-release/actions