Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: move metadata to setup.cfg #38852

Merged
merged 56 commits into from
Feb 16, 2021

Conversation

fangchenli
Copy link
Member

move metadata to setup.cfg to separate them from build logic.

setup.cfg Show resolved Hide resolved
Comment on lines +12 to +14
# uncomment to enable pep517 after versioneer problem is fixed.
# https://github.com/python-versioneer/python-versioneer/issues/193
# build-backend = "setuptools.build_meta"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could modify PATH and uncomment this line to enable pep517. But I feel that may require some discussion.

@jreback jreback added the Build Library building on various platforms label Dec 31, 2020
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

great. can you build like this https://github.com/pandas-dev/pandas-release to make sure things look good (mainly testing that the sdist looks good).

@jreback jreback added this to the 1.3 milestone Dec 31, 2020
setup.cfg Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented Dec 31, 2020

cc @simonjayhawkins if you give this a quick test as well. shall we backport to 1.2.1?

@fangchenli
Copy link
Member Author

great. can you build like this https://github.com/pandas-dev/pandas-release to make sure things look good (mainly testing that the sdist looks good).

Is uploading the sdist to testpypi the only way to test this? I couldn't get the version right. It won't allow me to upload the sdist.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jan 1, 2021

Nice! I'd suggesting adding https://github.com/asottile/setup-cfg-fmt as a pre-commit hook

  - repo: https://github.com/asottile/setup-cfg-fmt
    rev: v1.16.0
    hooks:
      - id: setup-cfg-fmt

@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

@fangchenli you don't need to tag or upload

just build the sdist in master and then on your PR and compare that they have the same metadata

@MarcoGorelli MarcoGorelli self-requested a review January 2, 2021 07:28
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@simonjayhawkins
Copy link
Member

cc @simonjayhawkins if you give this a quick test as well. shall we backport to 1.2.1?

pip-test and conda-test failures, 74 failed.

eg. FileNotFoundError: [Errno 2] No such file or directory: '/opt/conda/envs/pip-test/lib/python3.7/site-packages/pandas/tests/io/parser/data/unicode_series.csv'

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jan 3, 2021

install from sdist and running pandas.test(extra_args=['-m not clipboard', '--skip-slow', '--skip-network', '--skip-db', '-n=2']) gives 87 failed which includes 13 failures seen at https://dev.azure.com/pandas-dev/pandas-wheels/_build/results?buildId=51595&view=logs&j=bb1c2637-64c6-57bd-9ea6-93823b2df951&t=9c62e7ff-391e-517d-ede1-af63bc6a25da&s=d654deb9-056d-50a2-1717-90c08683d50a

@jreback
Copy link
Contributor

jreback commented Jan 25, 2021

@simonjayhawkins @jorisvandenbossche this lgtm. looks like final comments have been addressed. merging tomorrow.

@simonjayhawkins
Copy link
Member

@simonjayhawkins should we consider keeping it? (I don't know how useful it is, or eg only on master)

we should maybe have this or something similar on ci. At the moment we will catch build errors on the nightly build.

but lets keep that discussion out of this PR.

@jorisvandenbossche
Copy link
Member

OK, sounds good

@simonjayhawkins
Copy link
Member

@fangchenli maybe we should open issues for conditional numpy import #38852 (comment) and ci check #38852 (comment)

@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

@fangchenli one more rebase and then will merge. ping on green.

@simonjayhawkins simonjayhawkins merged commit 8967241 into pandas-dev:master Feb 16, 2021
@simonjayhawkins
Copy link
Member

Thanks @fangchenli

@simonjayhawkins
Copy link
Member

@fangchenli the wheels doubled in size around the same time that this was merged. Could it be this PR that is responsible? https://anaconda.org/scipy-wheels-nightly/pandas/files?page=32

@fangchenli
Copy link
Member Author

@fangchenli the wheels doubled in size around the same time that this was merged. Could it be this PR that is responsible? https://anaconda.org/scipy-wheels-nightly/pandas/files?page=32

Looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants