-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: move metadata to setup.cfg #38852
BLD: move metadata to setup.cfg #38852
Conversation
# uncomment to enable pep517 after versioneer problem is fixed. | ||
# https://github.com/python-versioneer/python-versioneer/issues/193 | ||
# build-backend = "setuptools.build_meta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could modify PATH and uncomment this line to enable pep517. But I feel that may require some discussion.
great. can you build like this https://github.com/pandas-dev/pandas-release to make sure things look good (mainly testing that the sdist looks good). |
cc @simonjayhawkins if you give this a quick test as well. shall we backport to 1.2.1? |
Is uploading the sdist to testpypi the only way to test this? I couldn't get the version right. It won't allow me to upload the sdist. |
Nice! I'd suggesting adding https://github.com/asottile/setup-cfg-fmt as a pre-commit hook
|
@fangchenli you don't need to tag or upload just build the sdist in master and then on your PR and compare that they have the same metadata |
pip-test and conda-test failures, 74 failed. eg. |
install from sdist and running |
@simonjayhawkins @jorisvandenbossche this lgtm. looks like final comments have been addressed. merging tomorrow. |
we should maybe have this or something similar on ci. At the moment we will catch build errors on the nightly build. but lets keep that discussion out of this PR. |
OK, sounds good |
@fangchenli maybe we should open issues for conditional numpy import #38852 (comment) and ci check #38852 (comment) |
@fangchenli one more rebase and then will merge. ping on green. |
Thanks @fangchenli |
@fangchenli the wheels doubled in size around the same time that this was merged. Could it be this PR that is responsible? https://anaconda.org/scipy-wheels-nightly/pandas/files?page=32 |
Looking into it. |
move metadata to setup.cfg to separate them from build logic.