-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix pydantic test failures #429
base: main
Are you sure you want to change the base?
Bugfix/fix pydantic test failures #429
Conversation
…nits is wicked fast
…er and solve strange test breakage by renaming `period` field to `interval`
Can you elaborate on this please? I'd be very interested to see the logs |
Sure thing. I am running on an M1 machine for the first time and was totally baffled but after screwing with it for awhile the name
|
Thank you for submitting this, please allow some time for deeper RCA as the implications of this bug could be quite far reaching (model validation dict not including values when the model defines default values) |
There are other changes here that are not at all controversial. Marking the kubemetrics tests as integration is straightforward and an obvious oversight. |
As is pinning the Kubernetes library version to avoid inadvertent upgrades |
Fix weird test failures related to the
period
attribute by renaming tointerval
. Mark Kube Metrics test as part of the integration suite and pin Kubernetes version to keep kubetest happy and the unit tests fast