-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass, autosetting within canaryopt 'create' classmethod #424
base: main
Are you sure you want to change the base?
First pass, autosetting within canaryopt 'create' classmethod #424
Conversation
ENG-622 Auto-set the range of CPU and Memory
Auto-set the range of CPU and memory. Remove the requirement to configure the CPU and memory ranges (min and max), e.g., by using the formula that OKO uses (min = 0.5 * baseline, max = 1.5 * baseline) to derive default values based on the current value of baseline, while still allowing explicit values to be set |
@linkous8 can you let me know if this is the right idea, mainly as far as where this logic should take place? And for the actual multipliers (just hardcoded temporarily for testing), do you think they should be constants somewhere or perhaps part of the config? |
@linkous8 I moved the logic to |
if not self.cpu: | ||
self.cpu = CPU(min="250m", max="3000m") | ||
if not self.memory: | ||
self.memory = Memory(min="256 MiB", max="3.0 GiB") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have these famous random values versus just raising?
|
No description provided.