Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gross anatomical part. Fixes #2921 #3374

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Sep 23, 2024

@cmungall cmungall requested a review from dosumis October 17, 2024 21:20
@cmungall
Copy link
Member Author

cmungall commented Oct 17, 2024

Unsatisfiable - Joeys are not substances

image

@cmungall cmungall mentioned this pull request Oct 17, 2024
2 tasks
@cmungall
Copy link
Member Author

This is turning out to be harder than I expected

@gouttegd
Copy link
Collaborator

gouttegd commented Oct 18, 2024

Unsatisfiable - Joeys are not substances

We have encountered this one before, and it was agreed that the

'median vaginal canal' SubClassOf: 'channel for' some embryo

axiom should be removed, but then there was no follow-up…

Edit: My bad, I’ve just seen that you did exactly that in the subsequent commit. Sorry for the noise.

@gouttegd
Copy link
Collaborator

Regarding the last QC failure, I believe you have run into what should be considered a bug in the ODK. I have opened an issue with the details on the ODK repo.

A quick (but crude) workaround until the issue is fixed in the ODK would be to edit the standard Makefile to change the definition of $(SRCMERGED) from

SRCMERGED     = $(TMPDIR)/merged-$(SRC)

into

SRCMERGED     = $(TMPDIR)/merged-uberon-edit.ofn

to force the intermediate file on which the ROBOT report command is run to be written in OFN rather than OBO format, thereby avoiding OBO serialisation quirks.

@anitacaron anitacaron removed their request for review November 13, 2024 17:03
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants