Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Actually attempt to get the GitHub app's user ID (#5214)" #5217

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Revert "Actually attempt to get the GitHub app's user ID (#5214)" #5217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions internal/providers/github/clients/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,7 @@ func (g *GitHubAppDelegate) ListAllRepositories(ctx context.Context) ([]*minderv
// GetUserId returns the user id for the GitHub App user
func (g *GitHubAppDelegate) GetUserId(ctx context.Context) (int64, error) {
// Try to get this user ID from the GitHub API
//nolint:errcheck // this will never error
appUserName, _ := g.GetName(ctx)
user, _, err := g.client.Users.Get(ctx, appUserName)
user, _, err := g.client.Users.Get(ctx, "")
if err != nil {
// Fallback to the configured user ID
// note: this is different from the App ID
Expand Down
Loading