Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Actually attempt to get the GitHub app's user ID (#5214)" #5217

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

eleftherias
Copy link
Contributor

This reverts commit 9286b31.

Summary

This was breaking provider enrolment. We are abusing this function by using it for both the bot App user and the enrolling real user. We should refactor, but reverting for now.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner December 17, 2024 14:55
@eleftherias eleftherias merged commit ad7c2d2 into mindersec:main Dec 17, 2024
25 checks passed
@eleftherias eleftherias deleted the revert-user-id branch December 17, 2024 15:06
@coveralls
Copy link

Coverage Status

coverage: 54.996% (-0.01%) from 55.009%
when pulling aa1a687 on eleftherias:revert-user-id
into 9286b31 on mindersec:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants