-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PullRequestCommenter provider trait #5188
base: main
Are you sure you want to change the base?
Conversation
75ccc33
to
6cb2cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
@JAORMX - oops, CI seems quite red |
71abfd7
to
386fb02
Compare
ctx context.Context, owner, repoName string, prNum int64, authorizedUser int64, | ||
) (magicCommentInfo, error) { | ||
// TODO: overflow | ||
comments, _, err := c.client.Issues.ListComments(ctx, owner, repoName, int(prNum), |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.ParseInt
Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
} | ||
|
||
// TODO: overflow | ||
_, err := c.DismissReview(ctx, owner, repoName, int(prNumber), mci.ReviewID, dismissReview) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.ParseInt
Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
This allows for providers to comment on pull requests Signed-off-by: Juan Antonio Osorio <[email protected]>
|
||
ic, err := c.CreateIssueComment(ctx, owner, repoName, | ||
// TODO: overflow | ||
int(prNumber), body) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.ParseInt
Incorrect conversion of a signed 64-bit integer from
strconv.ParseInt
} | ||
|
||
// TODO: overflow | ||
r, err := c.CreateReview(ctx, owner, repoName, int(prNumber), review) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
strconv.ParseInt
Incorrect conversion of a signed 64-bit integer from
Summary
This allows for providers to comment on pull requests
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: