Unified PR machinery for actions like pull request comment #5223
+1,037
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for providers to comment on pull requests Signed-off-by: Juan Antonio Osorio <[email protected]>
This shared space will allow actions to gather structures or results that will allow it to aggregate and flush. In more solid terms, we'd be able to aggregate PR comments, iterate them, and issue just one big comment. Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| type minderTemplateData struct { | ||
| MagicComment string | ||
| Body string | ||
| } |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
|
|
||
| ic, err := c.CreateIssueComment(ctx, owner, repoName, | ||
| // TODO: overflow | ||
| int(prNumber), body) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
|
|
||
| func (c *GitHub) createReview( | ||
| ctx context.Context, comment provifv1.PullRequestCommentInfo, mci magicCommentInfo, | ||
| owner, repoName string, prNumber int64, commitSha string, |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
| // TODO: overflow | ||
| r, err := c.CreateReview(ctx, owner, repoName, int(prNumber), review) | ||
| if err != nil { | ||
| return mci, fmt.Errorf("could not create review: %w", err) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds all the needed machinery and implementation to create a unified actions result. This is specially useful for aggregating results from different alerts such as pull_request_comment.
I tried doing it in separate PRs... see #5188 & #5182 but this proved challenging. So now it's all here.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: