Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): disambiguate report.csv artifact name #34110

Merged
merged 1 commit into from
Dec 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests_bidi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ jobs:
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: csv-report
name: csv-report-${{ matrix.channel }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other PR where you created the CSV report I can see that the report is uploaded as zip. Can this be changed so that the .csv is directly available for import? Or will you make a duplicate at some other place so that we can have a stable URL to point to for IMPORTDATA in that Google spreadsheet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how GitHub artifacts work. I don't think we can change that. But if you want the file to be uploaded somewhere else, we can add an action for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a place in mind where to upload it, feel free to send a PR adding an action. We can also try to upload it into blob store similar to how we do with html reports today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34122 should upload each report to the same url in the blob store.

path: test-results/report.csv
retention-days: 7
Loading