Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): disambiguate report.csv artifact name #34110

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 20, 2024

Fixes the following error:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

@@ -48,6 +48,6 @@ jobs:
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: csv-report
name: csv-report-${{ matrix.channel }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other PR where you created the CSV report I can see that the report is uploaded as zip. Can this be changed so that the .csv is directly available for import? Or will you make a duplicate at some other place so that we can have a stable URL to point to for IMPORTDATA in that Google spreadsheet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how GitHub artifacts work. I don't think we can change that. But if you want the file to be uploaded somewhere else, we can add an action for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a place in mind where to upload it, feel free to send a PR adding an action. We can also try to upload it into blob store similar to how we do with html reports today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34122 should upload each report to the same url in the blob store.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

12 flaky ⚠️ [firefox-library] › library/client-certificates.spec.ts:705:3 › browser › support http2 if the browser only supports http1.1 @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:238:1 › should show params and return value @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1032:1 › should not crash with broken locator @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1091:1 › should pick locator @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1431:1 › should not record route actions @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37391 passed, 649 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 3bc72eb into microsoft:main Dec 20, 2024
28 of 31 checks passed
@yury-s yury-s deleted the bidi-report-suffix branch December 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants