Some improvements #677
Merged
Some improvements #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, they build the same executables.
Fixes 24765c3 Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
levitte
approved these changes
Nov 29, 2024
That has got to be the understatement of the month! 😆 |
|
Something is broken with the GH actions... but that doesn't seem to be particularly relevant for this PR |
|
With this, I think #675 can be closed without merging it. |
Signed-off-by: Steffen Jaeckel <[email protected]>
This reverts 85dc394 Signed-off-by: Steffen Jaeckel <[email protected]>
Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
some-improvements
branch
3 times, most recently
from
43d86dd to
842b8b0
Compare
* add `ltc` wrapper script for installed demos * rework demos/CMakeLists.txt and add some more bells and whistles * prefix installed demos with `ltc-` Currently this makes the standard makefiles and CMake results diverge, but we can fix that later if required. Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
some-improvements
branch
from
842b8b0 to
88dcebd
Compare
yeah no, I broke them ... but I've also fixed them again :)
😄 OK, I've updated the comment (...a bit ;) ) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check commit messages for details.
This fixes #671
This fixes #675