Some improvements #678
Merged
Some improvements #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
force-pushed
the
some-improvements
branch
2 times, most recently
from
ae6713e to
661fd96
Compare
|
I added a fixup patch to give the compiler a chance to warn if @sjaeckel, you know how to handle such commits, yeah? |
levitte
approved these changes
Dec 11, 2024
Signed-off-by: Steffen Jaeckel <[email protected]>
* `CONSTPTR()` must be 32bit. * `CRYPT_HASH_OVERFLOW` test operates on `unsigned long`, which is only 32bit wide on x32. Signed-off-by: Steffen Jaeckel <[email protected]>
* Add at least a `-h` option, sometimes more. * Fix the exit codes of some of them. * Make them all compile with `LTC_EASY`. Signed-off-by: Steffen Jaeckel <[email protected]>
... at least at compile time. Signed-off-by: Steffen Jaeckel <[email protected]>
There are cases where we want to use an MPI provider, but the package is not installed in the system, so `pkg-config` can't find it. To solve this simply ignore the errors created and only print something if the user asks us to by passing `V=1`. Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
some-improvements
branch
from
0446a75 to
87ff205
Compare
Fixes 2400883 Signed-off-by: Steffen Jaeckel <[email protected]>
Thanks! I've added one more patch with what resulted in the build failures of the previous PR, + one more clean-up patch. |
levitte
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more improvements on top of #677
@gregoa could you please check if this fixes the x32 build I've seen happening on Debian?