[WIP] Bump CAPI to v1.9.0

[mboersma]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.0.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

See controller-runtime v0.19 release notes: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0
See CAPI 1.8 - 1.9 migration guide: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
CAPA's PR, for comparison: kubernetes-sigs/cluster-api-provider-aws#5209

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Bump CAPI to v1.9.0

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[codecov]

Codecov Report

Attention: Patch coverage is 35.06494% with 50 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (61c6f3f) to head (3cd8220).

Files with missing lines	Patch %	Lines
main.go	0.00%	18 Missing ⚠️
controllers/asosecret_controller.go	0.00%	5 Missing ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go	0.00%	5 Missing ⚠️
controllers/azureasomanagedcluster_controller.go	0.00%	4 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go	0.00%	3 Missing ⚠️
controllers/azurejson_machine_controller.go	0.00%	3 Missing ⚠️
controllers/azurejson_machinepool_controller.go	0.00%	3 Missing ⚠️
...ontrollers/azurejson_machinetemplate_controller.go	0.00%	3 Missing ⚠️
azure/scope/machine.go	0.00%	1 Missing ⚠️
azure/scope/machinepool.go	0.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5316      +/-   ##
==========================================
- Coverage   52.51%   52.50%   -0.02%     
==========================================
  Files         272      272              
  Lines       29431    29438       +7     
==========================================
  Hits        15457    15457              
- Misses      13172    13179       +7     
  Partials      802      802              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint

[mboersma]

/test pull-cluster-api-provider-azure-ci-entrypoint
/test pull-cluster-api-provider-azure-verify

[mboersma]

I'm curious why the new controller-gen is making this type of change.

[mboersma]

/retitle [WIP] Bump CAPI to v1.9.0

[k8s-ci-robot]

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-azure-apidiff	3cd8220	link	false	/test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-apiversion-upgrade	3cd8220	link	true	/test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-capi-e2e	3cd8220	link	false	/test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-aks	3cd8220	link	true	/test pull-cluster-api-provider-azure-e2e-aks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.