Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump CAPI to v1.9.0-rc.0 #5299

Closed

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.9.0-beta.1.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.9.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 42 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (983bf8b) to head (534365a).

Files with missing lines Patch % Lines
main.go 0.00% 16 Missing ⚠️
controllers/asosecret_controller.go 0.00% 5 Missing ⚠️
...ntrollers/azureasomanagedmachinepool_controller.go 0.00% 5 Missing ⚠️
controllers/azureasomanagedcluster_controller.go 0.00% 4 Missing ⚠️
...trollers/azureasomanagedcontrolplane_controller.go 0.00% 3 Missing ⚠️
controllers/azurejson_machine_controller.go 0.00% 3 Missing ⚠️
controllers/azurejson_machinepool_controller.go 0.00% 3 Missing ⚠️
...ontrollers/azurejson_machinetemplate_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5299      +/-   ##
==========================================
- Coverage   52.53%   52.52%   -0.02%     
==========================================
  Files         272      272              
  Lines       29421    29428       +7     
==========================================
  Hits        15456    15456              
- Misses      13166    13173       +7     
  Partials      799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from ba4cef0 to b633fb1 Compare November 21, 2024 21:56
@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-capi-e2e

@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from b633fb1 to 735517d Compare November 25, 2024 16:11
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 25, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from 735517d to fb881d2 Compare November 26, 2024 20:43
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@mboersma
Copy link
Contributor Author

/retitle [WIP] Bump CAPI to v1.9.0-rc.0

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Bump CAPI to v1.9.0-beta.1 [WIP] Bump CAPI to v1.9.0-rc.0 Nov 26, 2024
@mboersma mboersma force-pushed the bump-capi-one-nine-oh branch from fb881d2 to 534365a Compare November 26, 2024 20:45
@k8s-ci-robot
Copy link
Contributor

@mboersma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-capi-e2e 534365a link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e 534365a link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks 534365a link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-apiversion-upgrade 534365a link true /test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/test pull-cluster-api-provider-azure-ci-entrypoint

@mboersma
Copy link
Contributor Author

mboersma commented Dec 2, 2024

/close

I'm going to reopen this as a draft PR to avoid wasting test resources while I figure out why clusterctl brings up a broken CAPZ cluster. See #5316.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closed this PR.

In response to this:

/close

I'm going to reopen this as a draft PR to avoid wasting test resources while I figure out why clusterctl brings up a broken CAPZ cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma mboersma deleted the bump-capi-one-nine-oh branch December 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants