Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add favicon #2853

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

docs: add favicon #2853

wants to merge 5 commits into from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 28, 2024

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 28, 2024
@ST-DDT ST-DDT self-assigned this Apr 28, 2024
@ST-DDT ST-DDT requested a review from a team as a code owner April 28, 2024 11:13
@netlify Netlify
Copy link

netlify bot commented Apr 28, 2024 •
edited
Loading

❌ Deploy Preview for fakerjs failed.

Name Link
🔨 Latest commit 9368195
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671d5269c2f43200071fee34

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (77ca5d7) to head (9368195).

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #2853    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2804     2804            
  Lines      216974   216974            
  Branches      579      960   +381     
========================================
+ Hits       216886   216894     +8     
+ Misses         88       80     -8

see 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox requested a review from a team April 28, 2024 13:16
xDivisionByZerox
xDivisionByZerox reviewed Apr 28, 2024
View reviewed changes
docs/public/favicon.svg
Copy link
Member

@xDivisionByZerox xDivisionByZerox Apr 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file could be optimized by using a tool like SVGOMG. I get a file size reduction from around 40% when doing so. Additionally, the paths are usually don't require a precision of more than 3 digits. You can round all of them using the "precision" slider on the mentioned tool.

This step will be required when uploading to simple-icons as well.

@matthewmayer
Copy link
Contributor

Could the favicon version still have a red mouth? As it doesn't need to be monochrome like the simple icons version?

@LitoMore
Copy link

LitoMore commented May 18, 2024 •
edited
Loading

I already made a monochrome one for you. Just use this below when submitting your PR on simple-icons:

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>FakerJS</title><path d="M18.424.112c-1.306.24-2.492 1.28-3.552 3.18-1.467-.403-4.96.012-6.884 1.208-2.711-2.076-5.812-1.196-5.812-1.196s1.042.182 1.291.42c-.961.19-3.66 1.474-3.456 4.432.412-.056.852-.287.852-.287s-.789 1.103.912 3.488c.132.185.743-1.278.743-1.278s-1.35 4.158 2.142 11.552c2.241 4.12 16.051 2.8 19.164-4.52.738-2.725-1.068-7.187-1.248-7.465.911-1.089 2.354-3.99.542-6.464l.604.083C23.111 2.04 21.968.813 18.895.717l.453-.644a3.4 3.4 0 0 0-.924.039m3.804 11.01c.537 1.165 1.405 3.594.818 5.47-2.077 6.346-15.627 8.707-17.763 4.527-1.6-3.201-1.886-4.28-2.26-6.98-.322-1.82.522-5.08 1.123-5.682 2.128-2.49 3.613-3.434 6.717-4.185 2.527-.611 5.602-.302 7.874 1.228s2.586 3.493 3.49 5.622M8.17 9.134c-1.438.238-2.792 1.609-3.344 3.23-.708 2.133-.033 3.65 1.375 4.058 1.096.318 2.102-.167 2.637-.953s.548-1.44 1.246-2.482c2.043-3.051-.628-3.76-.914-3.826a2.6 2.6 0 0 0-1-.027m6.95-1.14c-1.37.243-2.003 1.32-2.003 1.32-.982 1.837.699 2.623 2.031 3.434s1.724 1.967 3.707 1.438c1.304-.348 2.104-1.84 1.062-3.65-.75-1.301-2.192-2.17-3.453-2.467-.493-.115-.959-.143-1.344-.075m.954 1.723c.218-.043.454-.035.689.038.701.216 1.097.914.882 1.557a1 1 0 0 1-.068.163c-.09-.434-.43-.818-.918-.97-.64-.199-1.316.07-1.592.607-.142-.683.354-1.268 1.007-1.395m-8.332 1.836q.203-.034.4-.006c.417.058.79.317.947.728-.523-.307-1.239-.175-1.672.332a1.3 1.3 0 0 0-.25 1.306c-.56-.324-.832-1.193-.243-1.884.232-.272.523-.425.818-.475zm4.3 2.02c-.648.138-1.238.409-1.301.735-.102.523.676 1.4 1.507 1.397.419-.002.966-.244 1.466-.898.454-.592.366-1.138-.311-1.29a2 2 0 0 0-.23-.035 4 4 0 0 0-1.13.09m-.097.658c.443-.082.963-.097 1.068-.076.397.076.354.42-.096.727-.534.365-1.066.463-1.581-.173-.201-.248.166-.397.609-.479m3.356 1.297c-.482 1.593-1.889 1.572-2.403 1.082 0 0-1.259 1.602-2.906.305 0 0-.034.92.94 1.243.117.472.769 2.214 2.43 1.794 1.512-.382 1.564-2.224 1.407-2.601 1.06-.664.532-1.823.532-1.823m-2.494 2.088s.618.321 1.242.1c.174 1.946-2.09 2.138-2.393.451a2.85 2.85 0 0 0 1.15-.551"/></svg>

It's optimized with SVGO and passed on the Simple Icons linter.

Simple Icons preview:

image

This used https://wasm.simpleicons.org/preview for generating preview.

ST-DDT EDIT: Preview:

image

image

@ST-DDT
Copy link
Member Author

ST-DDT commented May 18, 2024

Could the favicon version still have a red mouth? As it doesn't need to be monochrome like the simple icons version?

If the website doesn't use a monochrome Image, should it also retain the color gradient?
E.g. for the ears:

grafik

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented May 19, 2024 •
edited
Loading

Could we get a preview of the icons with the following variations?

  • as it is right now
  • as it is right now + mouth
  • as it is right now + gradient on ears
  • as it is right now + mouth + gradient on ears

right now = this PR = ba52684

@ST-DDT ST-DDT marked this pull request as draft June 2, 2024 13:41
@ST-DDT ST-DDT linked an issue Jul 4, 2024 that may be closed by this pull request
create icon on simple-icons #2827
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.

create icon on simple-icons
4 participants
@ST-DDT @matthewmayer @LitoMore @xDivisionByZerox