-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create icon on simple-icons #2827
Comments
For what purpose do you need the logo? |
to add a badge to my readme file indicates i'm using fakerjs in my project. |
I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷 Why would you open an issue here instead at the simple icon repo, tho? 🤔 (I have no idea how the process works) |
I don't know if this issue can harm anybody.
I guess the author has a better idea about how the icon should look like.
https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon |
What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.
I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.
Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: " |
How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg Powered by FakerJSWe might have to clean it up some more though, because at low screen sizes it gets indistinguishable. |
looks cool |
IMO it is still very had to see properly when small. |
Or just the magic hat? |
I'll try that tomorrow. |
I think the panda head is most visible at small sizes. |
the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg Panda head or magic hat works for me. |
I will make some more variant soon. |
|
Team Decision
|
I'm "soft blocking" this issue as I'd like to talk about UI/UX related topics in our next teem meeting, next thursday. |
Hi, I'm the maintainer of Simple Icons. Once you're ready, PRs are welcome. Feel free to ping me if you need help with contributing. My suggestion for the badge is to use the whiteish color for the left-side background. For example: <!-- I used the foodpanda icon as an example since your logo is not on Simple Icons yet. -->
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd&style=flat-square) |
to create badges like
[![vitest](https://img.shields.io/badge/Vitest-729b1b?logo=Vitest&labelColor=grey)](https://vitest.dev/)
the logo has to be available on https://wasm.simpleicons.org/?q=faker, the logo can be added to this repo https://github.com/simple-icons/simple-iconsThe text was updated successfully, but these errors were encountered: