Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create icon on simple-icons #2827

Open
ianzone opened this issue Apr 15, 2024 · 32 comments · May be fixed by #2853
Open

create icon on simple-icons #2827

ianzone opened this issue Apr 15, 2024 · 32 comments · May be fixed by #2853
Labels
c: external Issues that related to external services p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: needs decision Needs team/maintainer decision
Milestone

Comments

@ianzone
Copy link

ianzone commented Apr 15, 2024

to create badges like vitest [![vitest](https://img.shields.io/badge/Vitest-729b1b?logo=Vitest&labelColor=grey)](https://vitest.dev/) the logo has to be available on https://wasm.simpleicons.org/?q=faker, the logo can be added to this repo https://github.com/simple-icons/simple-icons

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: awaiting more info Additional information are requested c: external Issues that related to external services labels Apr 15, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

For what purpose do you need the logo?

@ianzone
Copy link
Author

ianzone commented Apr 15, 2024

to add a badge to my readme file indicates i'm using fakerjs in my project.

@ST-DDT ST-DDT removed the s: awaiting more info Additional information are requested label Apr 15, 2024
@xDivisionByZerox
Copy link
Member

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

Why would you open an issue here instead at the simple icon repo, tho? 🤔 (I have no idea how the process works)

@ianzone
Copy link
Author

ianzone commented Apr 15, 2024

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

I don't know if this issue can harm anybody.

Why would you open an issue here instead at the simple icon repo, tho? 🤔

I guess the author has a better idea about how the icon should look like.

(I have no idea how the process works)

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

@xDivisionByZerox
Copy link
Member

I don't know if this issue can harm anybody.

What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.

I guess the author has a better idea about how the icon should look like.

I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: "(I don't know how their process works) I got it now!"
I did not expect you to answer this fast 😄

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg

Powered by FakerJS

We might have to clean it up some more though, because at low screen sizes it gets indistinguishable.

@ianzone
Copy link
Author

ianzone commented Apr 15, 2024

The outline is good, could you add some color to it? Otherwise, it would be very dark on a dark background.
image

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

The icons have to be black and transparent. I can add a white background for better visualization on darkmode.

Powered by FakerJS

@ianzone
Copy link
Author

ianzone commented Apr 15, 2024

looks cool

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

Here a variant with only the face:

Powered by FakerJS

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

IMO it is still very had to see properly when small.
Maybe we have to focus just on the face and maybe fill it/invert the interior.

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

Here vitest for comparison:

Powered

@ianzone
Copy link
Author

ianzone commented Apr 15, 2024

Or just the magic hat?

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

face-2

Powered by FakerJS

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2024

Or just the magic hat?

I'll try that tomorrow.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Apr 17, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Apr 17, 2024

hat-1

Powered by FakerJS

@ianzone
Copy link
Author

ianzone commented Apr 18, 2024

image

@matthewmayer
Copy link
Contributor

I think the panda head is most visible at small sizes.

@Shinigami92
Copy link
Member

image

I like
image
the most

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

Please don't forget that there is usually no white background:

shield-bare
shield-face
shield-face-filled
shield-hat

@ianzone
Copy link
Author

ianzone commented Apr 18, 2024

the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg

Panda head or magic hat works for me.

@Shinigami92
Copy link
Member

And again,
image
wins for me

I think I found my favorite and decided (for me)

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

I will make some more variant soon.
Especially those with filled faces with default and no rotation.

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

face-3 shield-face2

Powered by FakerJS

@Shinigami92
Copy link
Member

face-3 shield-face2

Powered by FakerJS

dont like :(

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

face-filled-2 shield-face-filled2

Powered by FakerJS

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

face-filled-3 shield-face-filled3

Powered by FakerJS

@ST-DDT
Copy link
Member

ST-DDT commented Apr 18, 2024

For better comparison:

  • face-filled-1 shield-face-filled - ~50% rotation
  • face-filled-2 shield-face-filled2 - original rotation
  • face-filled-3 shield-face-filled3 - zero rotation

@Shinigami92
Copy link
Member

face-filled-1 wins for me

@ST-DDT
Copy link
Member

ST-DDT commented Apr 25, 2024

Team Decision

  • We will use face-filled-1
  • We will create a PR to upload the icon there.

@ST-DDT ST-DDT added this to the vAnytime milestone Apr 25, 2024
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Apr 25, 2024
@ST-DDT ST-DDT self-assigned this Apr 25, 2024
@ST-DDT ST-DDT linked a pull request Apr 28, 2024 that will close this issue
@xDivisionByZerox xDivisionByZerox added the s: needs decision Needs team/maintainer decision label Apr 28, 2024
@xDivisionByZerox
Copy link
Member

I'm "soft blocking" this issue as I'd like to talk about UI/UX related topics in our next teem meeting, next thursday.

@LitoMore
Copy link

LitoMore commented May 18, 2024

Hi, I'm the maintainer of Simple Icons. Once you're ready, PRs are welcome. Feel free to ping me if you need help with contributing.

My suggestion for the badge is to use the whiteish color for the left-side background. For example:

<!-- I used the foodpanda icon as an example since your logo is not on Simple Icons yet. -->
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=fff&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=eee&style=flat-square)
![](https://img.shields.io/badge/faker-779B2E?logo=foodpanda&logoColor=000&labelColor=ddd&style=flat-square)






@ST-DDT ST-DDT removed their assignment Jun 2, 2024
@ST-DDT ST-DDT linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: external Issues that related to external services p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: needs decision Needs team/maintainer decision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants