Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrettyNaming: remove the extra checks in AddBackticksToIdentifierIfNeeded #16614

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

PrettyNaming: remove the extra checks in AddBackticksToIdentifierIfNeeded #16614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68d360e
PrettyNaming: remove the extra checks in `AddBackticksToIdentifierIfN…
auduchinok Jan 30, 2024
e9603c0
Fantomas
auduchinok Feb 1, 2024
9ea751d
Release notes
auduchinok Feb 1, 2024
4c9f522
Release notes
auduchinok Feb 1, 2024
74c194c
Merge branch 'main' into backticks
0101 Feb 2, 2024
17bd6c8
Merge branch 'main' into backticks
vzarytovskii Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/release-notes/.FSharp.Compiler.Service/8.0.300.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Fix discriminated union initialization. ([#PR 16661](https://github.com/dotnet/fsharp/pull/16661))
* Allow calling method with both Optional and ParamArray. ([#PR 16688](https://github.com/dotnet/fsharp/pull/16688), [suggestions #1120](https://github.com/fsharp/fslang-suggestions/issues/1120))
* Enforce AttributeTargets on let values and functions. ([PR #16692](https://github.com/dotnet/fsharp/pull/16692))
* Pretty naming: remove extra checks in `AddBackticksToIdentifierIfNeeded` ([PR #16614](https://github.com/dotnet/fsharp/pull/16614))

### Added

Expand All @@ -22,6 +23,7 @@
* Allow returning bool instead of unit option for partial active patterns. ([Language suggestion #1041](https://github.com/fsharp/fslang-suggestions/issues/1041), [PR #16473](https://github.com/dotnet/fsharp/pull/16473))
* Symbols: Add GenericArguments to FSharpEntity ([PR #16470](https://github.com/dotnet/fsharp/pull/16470))


### Changed

* Autogenerated .Is* members for unions skipped for single-case unions. ([PR 16571](https://github.com/dotnet/fsharp/pull/16571))
Expand Down
6 changes: 1 addition & 5 deletions src/Compiler/SyntaxTree/PrettyNaming.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,11 +529,7 @@ let DoesIdentifierNeedBackticks (name: string) : bool =

/// A utility to help determine if an identifier needs to be quoted
let AddBackticksToIdentifierIfNeeded (name: string) : string =
if
DoesIdentifierNeedBackticks name
&& not (name.StartsWithOrdinal("`"))
&& not (name.EndsWithOrdinal("`"))
then
if DoesIdentifierNeedBackticks name then
"``" + name + "``"
else
name
Expand Down
Loading