Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrettyNaming: remove the extra checks in AddBackticksToIdentifierIfNeeded #16614

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

PrettyNaming: remove the extra checks in AddBackticksToIdentifierIfNeeded #16614

wants to merge 6 commits into from

Conversation

auduchinok
Copy link
Member

Tries to fix the normalization of identifiers like this one:

```foo`.``

@auduchinok auduchinok requested a review from a team as a code owner January 30, 2024 16:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

auduchinok

This comment was marked as resolved.

Sign in to view

@psfinaki
Copy link
Member

psfinaki commented Feb 1, 2024

Any tests here? :) I think we had something for pretty naming.

@auduchinok
Copy link
Member Author

I think we had something for pretty naming.

Could you point me to them, if you have an idea of where to look at, please?

@psfinaki
Copy link
Member

psfinaki commented Feb 2, 2024

Mmm this I guess? 👀

@vzarytovskii
Copy link
Member

Tries to fix the normalization of identifiers like this one:

```foo`.``

Is this missing something or ready to merge?

@auduchinok
Copy link
Member Author

Is this missing something or ready to merge?

I think I should add some tests, as @psfinaki has suggested. Otherwise it should be good to go in.

@abonie
Copy link
Member

abonie commented May 6, 2024

Converting to draft for the time being, since it is still missing the tests

@abonie abonie marked this pull request as draft May 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@auduchinok @psfinaki @vzarytovskii @abonie @edgarfgp @T-Gro @0101