-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libc++ #9558
Open
grendello
wants to merge
25
commits into
main
Choose a base branch
from
dev/grendel/use-libc++
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use libc++ #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/use-libc++
branch
3 times, most recently
from
December 3, 2024 12:40
0e11dc4
to
cdf9a44
Compare
* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions
In process to remove object instances for a slightly faster startup
Build is broken atm
grendello
force-pushed
the
dev/grendel/use-libc++
branch
from
December 3, 2024 14:11
cdf9a44
to
5a4d188
Compare
* main: [native] More C++ tweaks and changes (#9478) Add android-platform-support to .gitignore (#9590) [ci] Skip JDK install if near match is found in $(JI_JAVA_HOME) (#9585) Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 10653360 (#9587) Revert "Try dependabot max_length param (#9529)" Try dependabot max_length param (#9529) LEGO: Pull request (#9575) Bump to DevDiv/android-platform-support@52dd010a (#9553) Localized file check-in by OneLocBuild Task (#9574)
grendello
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
December 5, 2024 16:17
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always statically link libc++ into our runtime and enable
C++ exceptions, needed for future work.
Additionally, transition from traditional C
printf
style logging toC++
std::format
. The advantage is that the format string is moreexpressive (doesn't require knowing the argument type, allows for positional
placeholders as well as extra formatting specifiers, if needed), safer (all
arguments are type-checked at build time) and faster (format strings are parsed and
verified at build time, runtime involves only string rendering)