-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLR hosting #9572
Draft
grendello
wants to merge
57
commits into
main
Choose a base branch
from
dev/grendel/clr-host
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CLR hosting #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/clr-host
branch
from
December 3, 2024 12:41
cbc08f4
to
0370d7d
Compare
* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions
In process to remove object instances for a slightly faster startup
Build is broken atm
grendello
force-pushed
the
dev/grendel/clr-host
branch
2 times, most recently
from
December 3, 2024 21:15
c085352
to
13bbd93
Compare
Comment on lines
-42
to
+45
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" /> | ||
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" /> | ||
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" /> | ||
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" /> | ||
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so" /> | ||
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fixing this up in #9583, but maybe I can split up part of it into a smaller PR.
grendello
force-pushed
the
dev/grendel/clr-host
branch
from
December 4, 2024 18:47
13bbd93
to
82cfb8a
Compare
* Add a version script which hides all the symbols except for the handful we have to export. * Enable exceptions
In process to remove object instances for a slightly faster startup
Build is broken atm
grendello
force-pushed
the
dev/grendel/clr-host
branch
from
December 4, 2024 22:10
82cfb8a
to
77aa40a
Compare
* main: [native] More C++ tweaks and changes (#9478) Add android-platform-support to .gitignore (#9590) [ci] Skip JDK install if near match is found in $(JI_JAVA_HOME) (#9585) Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 10653360 (#9587) Revert "Try dependabot max_length param (#9529)" Try dependabot max_length param (#9529) LEGO: Pull request (#9575) Bump to DevDiv/android-platform-support@52dd010a (#9553) Localized file check-in by OneLocBuild Task (#9574)
* dev/grendel/use-libc++: (24 commits) Address feedback std::format doesn't like null pointers when printing strings Update apkdesc files Cleanup Cleanup Friendlier, no need to use `std::format` directly in log_* anymore More std::format Conversion to std::format continues A bit less of reinterpret_cast<> Start using std::format and std::string_view string literals Cleanup Lengths and offsets... Cleanup Trying to find out why AppContext.GetData doesn't appear to work Buglets fixed MonodroidRuntime is static now More move to static, more cleanup More cleanup Making EmbeddedAssemblies a static type More consistent use of std::string_view + remove unused code ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR includes changes from #9558, it will be smaller once #9558 is merged into
main
.