Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLR hosting #9572

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from
Draft

CLR hosting #9572

wants to merge 57 commits into from

Conversation

grendello
Copy link
Contributor

@grendello grendello commented Dec 2, 2024

Note: this PR includes changes from #9558, it will be smaller once #9558 is merged into main.

@grendello grendello force-pushed the dev/grendel/clr-host branch from cbc08f4 to 0370d7d Compare December 3, 2024 12:41
@grendello grendello force-pushed the dev/grendel/clr-host branch 2 times, most recently from c085352 to 13bbd93 Compare December 3, 2024 21:15
Comment on lines -42 to +45
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" />
<_AndroidRuntimePackAssets Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" />
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.debug.so" />
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libmono-android.release.so" />
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.debug.so" />
<_AndroidRuntimePackAssets Condition=" Exists('$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so') " Include="$(MicrosoftAndroidSdkOutDir)lib\$(AndroidRID)\libnet-android.release.so" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing this up in #9583, but maybe I can split up part of it into a smaller PR.

@grendello grendello force-pushed the dev/grendel/clr-host branch from 13bbd93 to 82cfb8a Compare December 4, 2024 18:47
  * Add a version script which hides all the symbols except for the
    handful we have to export.
  * Enable exceptions
@grendello grendello force-pushed the dev/grendel/clr-host branch from 82cfb8a to 77aa40a Compare December 4, 2024 22:10
* main:
  [native] More C++ tweaks and changes (#9478)
  Add android-platform-support to .gitignore (#9590)
  [ci] Skip JDK install if near match is found in $(JI_JAVA_HOME) (#9585)
  Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 10653360 (#9587)
  Revert "Try dependabot max_length param (#9529)"
  Try dependabot max_length param (#9529)
  LEGO: Pull request (#9575)
  Bump to DevDiv/android-platform-support@52dd010a (#9553)
  Localized file check-in by OneLocBuild Task (#9574)
* main:
  [native] More C++ tweaks and changes (#9478)
  Add android-platform-support to .gitignore (#9590)
* dev/grendel/use-libc++: (24 commits)
  Address feedback
  std::format doesn't like null pointers when printing strings
  Update apkdesc files
  Cleanup
  Cleanup
  Friendlier, no need to use `std::format` directly in log_* anymore
  More std::format
  Conversion to std::format continues
  A bit less of reinterpret_cast<>
  Start using std::format and std::string_view string literals
  Cleanup
  Lengths and offsets...
  Cleanup
  Trying to find out why AppContext.GetData doesn't appear to work
  Buglets fixed
  MonodroidRuntime is static now
  More move to static, more cleanup
  More cleanup
  Making EmbeddedAssemblies a static type
  More consistent use of std::string_view + remove unused code
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants