Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-indicspecies package #27617

Merged
merged 12 commits into from
Sep 19, 2024

Conversation

PaulineSGN
Copy link
Contributor

@PaulineSGN PaulineSGN commented Sep 18, 2024

Adding Indicspecies R package to Conda from CRAN thanks to the conda_r_skeleton_helper, and making it available for Galaxy

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-indicspecies/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-indicspecies/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@PaulineSGN
Copy link
Contributor Author

@conda-forge/r clould you please be maintainer for this recipe ?

@PaulineSGN
Copy link
Contributor Author

@conda-forge/help-r I think this recipe is ready for review. However, the windows build is failing maybe due to the same thing as in the issue #25319

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! ❤️

Yes, Windows failures can be ignored on noarch recipes and we're happy to help maintain.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-indicspecies/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.
  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: generic.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-indicspecies/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: generic.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-indicspecies/meta.yaml:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [17]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-indicspecies/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert to the previously reviewed version.

recipes/r-indicspecies/meta.yaml Outdated Show resolved Hide resolved
recipes/r-indicspecies/meta.yaml Outdated Show resolved Hide resolved
@PaulineSGN
Copy link
Contributor Author

Hi @mfansler ! Thanks a lot for your help, it should be good now.

@mfansler mfansler merged commit f596b85 into conda-forge:main Sep 19, 2024
4 of 6 checks passed
@PaulineSGN PaulineSGN deleted the add-r-indicspecies-package branch September 19, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants