Fix oneof schema #72
Closed
Fix oneof schema #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shares history with #69 . merge that first, and then rebase this or open a new PR. closing so nobody reviews and you are free to rewrite the git history of the PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#70
Description of changes:
Looking at how
ResourceTypeSchemais used, I'm rather convinced that it should not subclass fromObjectSchema(orSchema) at all. Its primary use is to provide strongly-typed access to schema elements; this can be done if the schema is contained within. Currently nothing uses ResourceTypeSchema to validate actual CFN templates, but if necessary, this can be easily done by forwarding "validate" call to theschemamemberBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.