Validate ref #69
Merged
Validate ref #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
this shares history with #68 - need to get that merged first. i've already closed #72 , because three dependent PRs is definitely too much. if you want to leave this one open for review, you'll have to get #68 merged first, and then merge edit: fixed |
vladtsir
commented
Dec 16, 2019
vladtsir
commented
Dec 16, 2019
vladtsir
commented
Dec 16, 2019
Merged
rjlohan
suggested changes
Dec 17, 2019
src/test/java/software/amazon/cloudformation/resource/ValidatorRefResolutionTests.java
Outdated
Show resolved
Hide resolved
Merged
tobywf
reviewed
Dec 18, 2019
src/test/java/software/amazon/cloudformation/resource/ValidatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/ValidatorRefResolutionTests.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/ValidatorRefResolutionTests.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/resource/Validator.java
Outdated
Show resolved
Hide resolved
tobywf
approved these changes
Dec 20, 2019
| try { | ||
| return loader.load(); | ||
| } catch (org.everit.json.schema.SchemaException e) { | ||
| throw new ValidationException(e.getMessage(), e.getSchemaLocation(), e); |
There was a problem hiding this comment.
could we convert the SchemaException to a org.everit.json.schema.ValidationException and keep using causingExceptions instead?
johnttompkins
approved these changes
Dec 20, 2019
rjlohan
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#23
Description of changes:
Everit validates $ref values, when a Schema is created using SchemaLoader$load().
This change adds loading resource definition as a schema with ResourceDefinitionSchema and JSON schema registered as meta-schemas. Unit tests show that invalid references cause SchemaLoader to throw a ValidationException.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.