Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Azure workload identity for Git and OCI repositories. #21118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jagpreetstamber
Copy link

@jagpreetstamber jagpreetstamber commented Dec 10, 2024

PR implements Azure workload identity authentication mechanism for authenticating with the Azure Git and OCI repositories

Azure Workload Identity enables the credential free authentication for Azure customers, enabling this feature will remove the credential management overhead from customers using argo on Azure Kubernetes clusters.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes. Support for Azure Entra workload identity  #13334
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jagpreetstamber jagpreetstamber requested a review from a team as a code owner December 10, 2024 15:36
Copy link

bunnyshell bot commented Dec 10, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@jagpreetstamber jagpreetstamber force-pushed the master branch 7 times, most recently from d15b63d to fdf129b Compare December 10, 2024 17:33
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 64.57680% with 113 lines in your changes missing coverage. Please review.

Project coverage is 55.24%. Comparing base (d7ccf47) to head (88ea8cf).

Files with missing lines Patch % Lines
util/helm/creds.go 79.48% 24 Missing and 8 partials ⚠️
util/helm/cmd.go 52.50% 14 Missing and 5 partials ⚠️
pkg/apis/application/v1alpha1/repository_types.go 22.22% 12 Missing and 2 partials ⚠️
util/git/creds.go 65.00% 11 Missing and 3 partials ⚠️
util/util.go 0.00% 8 Missing ⚠️
util/git/client.go 0.00% 7 Missing ⚠️
util/db/repository_secrets.go 57.14% 4 Missing and 2 partials ⚠️
util/workloadidentity/workloadidentity.go 73.33% 4 Missing ⚠️
util/helm/client.go 76.92% 1 Missing and 2 partials ⚠️
cmd/argocd/commands/repo.go 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21118      +/-   ##
==========================================
+ Coverage   53.26%   55.24%   +1.98%     
==========================================
  Files         337      339       +2     
  Lines       57055    57318     +263     
==========================================
+ Hits        30391    31666    +1275     
+ Misses      24012    22935    -1077     
- Partials     2652     2717      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

util/helm/cmd.go Fixed Show fixed Hide fixed
util/helm/cmd.go Fixed Show fixed Hide fixed
@jagpreetstamber jagpreetstamber force-pushed the master branch 2 times, most recently from da35f8a to b3002cf Compare December 13, 2024 00:53
@jagpreetstamber jagpreetstamber marked this pull request as ready for review December 13, 2024 00:55
@jagpreetstamber jagpreetstamber force-pushed the master branch 4 times, most recently from ace9f8e to f0c93ca Compare December 13, 2024 21:18
@jagpreetstamber jagpreetstamber force-pushed the master branch 13 times, most recently from 613d683 to fb18b64 Compare December 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant