Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Workload identity support for Azure DevOps and Azure Container Registry #20086

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cveld
Copy link

@cveld cveld commented Sep 24, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes issue #13334

Some questions where help from core contributors is desired:

  • Bump versions of azure dependencies – argocd-k8s-auth
  • Git / helm package boundaries
  • Testing
  • Data model
  • Cli support
  • Webapp support
  • Bunnyshell

@cveld cveld requested a review from a team as a code owner September 24, 2024 19:37
Copy link

bunnyshell bot commented Sep 24, 2024

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Sep 24, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@cveld cveld force-pushed the cveld/workload-identity-support-for-azure-devops branch 2 times, most recently from 07b1c0e to 0e15bd9 Compare September 24, 2024 20:03
@cveld cveld requested a review from a team as a code owner September 24, 2024 20:03
@cveld cveld force-pushed the cveld/workload-identity-support-for-azure-devops branch from d9a9fc4 to aeabc5a Compare September 24, 2024 20:23
@cveld cveld force-pushed the cveld/workload-identity-support-for-azure-devops branch from aeabc5a to c734361 Compare September 24, 2024 20:26
@crenshaw-dev crenshaw-dev marked this pull request as draft September 30, 2024 14:26
@crenshaw-dev
Copy link
Member

Marked as draft since this appears to still be WIP.

@cveld cveld changed the title WIP: Workload identity support for Azure DevOps WIP: Workload identity support for Azure DevOps and Azure Container Registry Oct 1, 2024
@todaywasawesome
Copy link
Contributor

Related PR trying to upgrade the Azure identity package #18843

@dtzar
Copy link

dtzar commented Nov 13, 2024

@cveld - there is a big need to get this into the product. Are you still working on this?

@jagpreetstamber
Copy link

I have changes implemented similar chages here: #21118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants