Normalize basePath in targetTables in ConversionController #602
+170
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinishjail97
force-pushed
the
IcebergSourceFix
branch
from
af55915 to
1137757
Compare
the-other-tim-brown
approved these changes
Dec 18, 2024
ashvina
reviewed
Dec 18, 2024
| * Few table formats need the metadata to be located at the root level of the data files. Eg: An | ||
| * iceberg table generated through spark will have two directories basePath/data and | ||
| * basePath/metadata For synchronising the iceberg metadata to hudi and delta, they need to be | ||
| * present in basePath/data/.hoodie and basePath/data/_delta_log. |
There was a problem hiding this comment.
Hi @vinishjail97
This observation is not accurate for delta lake. It is ok for the _delta_log to be present at the basePath level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
When iceberg tables are used as source, they can have different basePath and dataPaths, when synchronizing these tables to hudi and delta, the .hoodie and _delta_log directories should be present in
basePath/data/.hoodie, the current code generates the metadata atbasePath/.hoodieBrief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)