Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize basePath in targetTables in ConversionController #601

Closed
wants to merge 1 commit into from

Conversation

vinishjail97
Copy link
Contributor

@vinishjail97 vinishjail97 commented Dec 14, 2024

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

When iceberg tables are used as source, they can have different basePath and dataPaths, when synchronizing these tables to hudi and delta, the .hoodie and _delta_log directories should be present in basePath/data/.hoodie, the current code generates the metadata at basePath/.hoodie

Brief change log

(for example:)

  • Fixes the target base paths when source table format is ICEBERG with different basePath and dataPath

Verify this pull request

(Please pick either of the following options)

This change added tests and can be verified as follows:

(example:)

  • xtable-core/src/test/java/org/apache/xtable/ITConversionController.java
  • xtable-core/src/test/java/org/apache/xtable/conversion/TestConversionUtils.java

@vinishjail97
Copy link
Contributor Author

Closing this one as it's directly pushed to origin.
#602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant