route53_ksk - new module #2412

alinabuzachis · 2024-12-04T16:50:26Z

SUMMARY

Terminator PR mattclay/aws-terminator#312

Closes #1976

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

route53_ksk

ADDITIONAL INFORMATION

Signed-off-by: Alina Buzachis <[email protected]>

github-actions · 2024-12-04T16:56:15Z

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/amazon.aws/actions/runs/12375701016

You can compare to the docs for the main branch here:
https://ansible-collections.github.io/amazon.aws/branch/main

File changes:

A collections/amazon/aws/route53_ksk_module.html

M collections/amazon/aws/index.html

M collections/amazon/aws/route53_info_module.html

M collections/amazon/aws/route53_zone_module.html

M collections/index_module.html

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
index 756215f..809427f 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/index.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/index.html
@@ -346,6 +346,7 @@
 <li><p><a class="reference internal" href="route53_module.html#ansible-collections-amazon-aws-route53-module"><span class="std std-ref">route53 module</span></a> – add or delete entries in Amazons Route 53 DNS service</p></li>
 <li><p><a class="reference internal" href="route53_health_check_module.html#ansible-collections-amazon-aws-route53-health-check-module"><span class="std std-ref">route53_health_check module</span></a> – Manage health checks in Amazons Route 53 DNS service</p></li>
 <li><p><a class="reference internal" href="route53_info_module.html#ansible-collections-amazon-aws-route53-info-module"><span class="std std-ref">route53_info module</span></a> – Retrieves Route 53 details using AWS methods</p></li>
+<li><p><a class="reference internal" href="route53_ksk_module.html#ansible-collections-amazon-aws-route53-ksk-module"><span class="std std-ref">route53_ksk module</span></a> – Manages a key-signing key (KSK)</p></li>
 <li><p><a class="reference internal" href="route53_zone_module.html#ansible-collections-amazon-aws-route53-zone-module"><span class="std std-ref">route53_zone module</span></a> – add or delete Route 53 zones</p></li>
 <li><p><a class="reference internal" href="s3_bucket_module.html#ansible-collections-amazon-aws-s3-bucket-module"><span class="std std-ref">s3_bucket module</span></a> – Manage S3 buckets in AWS, DigitalOcean, Ceph, Walrus, FakeS3 and StorageGRID</p></li>
 <li><p><a class="reference internal" href="s3_bucket_info_module.html#ansible-collections-amazon-aws-s3-bucket-info-module"><span class="std std-ref">s3_bucket_info module</span></a> – Lists S3 buckets in AWS</p></li>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/route53_info_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/route53_info_module.html
index 3866d22..2e6cc1b 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/route53_info_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/route53_info_module.html
@@ -22,7 +22,7 @@
       <script src="../../../_static/sphinx_highlight.js?v=dc90522c"></script>
     <script src="../../../_static/js/theme.js"></script>
     <link rel="search" title="Search" href="../../../search.html" />
-    <link rel="next" title="amazon.aws.route53_zone module – add or delete Route 53 zones" href="route53_zone_module.html" />
+    <link rel="next" title="amazon.aws.route53_ksk module – Manages a key-signing key (KSK)" href="route53_ksk_module.html" />
     <link rel="prev" title="amazon.aws.route53_health_check module – Manage health checks in Amazons Route 53 DNS service" href="route53_health_check_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
@@ -1173,7 +1173,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-route53-
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
         <a href="route53_health_check_module.html" class="btn btn-neutral float-left" title="amazon.aws.route53_health_check module – Manage health checks in Amazons Route 53 DNS service" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
-        <a href="route53_zone_module.html" class="btn btn-neutral float-right" title="amazon.aws.route53_zone module – add or delete Route 53 zones" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+        <a href="route53_ksk_module.html" class="btn btn-neutral float-right" title="amazon.aws.route53_ksk module – Manages a key-signing key (KSK)" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
   <hr/>
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/route53_zone_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/route53_zone_module.html
index 571a00c..eab1cf2 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/route53_zone_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/route53_zone_module.html
@@ -23,7 +23,7 @@
     <script src="../../../_static/js/theme.js"></script>
     <link rel="search" title="Search" href="../../../search.html" />
     <link rel="next" title="amazon.aws.s3_bucket module – Manage S3 buckets in AWS, DigitalOcean, Ceph, Walrus, FakeS3 and StorageGRID" href="s3_bucket_module.html" />
-    <link rel="prev" title="amazon.aws.route53_info module – Retrieves Route 53 details using AWS methods" href="route53_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+    <link rel="prev" title="amazon.aws.route53_ksk module – Manages a key-signing key (KSK)" href="route53_ksk_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
 
 
 
@@ -621,7 +621,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-route53-
           
 
 <footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
-        <a href="route53_info_module.html" class="btn btn-neutral float-left" title="amazon.aws.route53_info module – Retrieves Route 53 details using AWS methods" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+        <a href="route53_ksk_module.html" class="btn btn-neutral float-left" title="amazon.aws.route53_ksk module – Manages a key-signing key (KSK)" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
         <a href="s3_bucket_module.html" class="btn btn-neutral float-right" title="amazon.aws.s3_bucket module – Manage S3 buckets in AWS, DigitalOcean, Ceph, Walrus, FakeS3 and StorageGRID" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
     </div>
 
diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
index be6d0c8..8b4c78a 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/index_module.html
@@ -254,6 +254,7 @@
 <li><p><a class="reference internal" href="amazon/aws/route53_module.html#ansible-collections-amazon-aws-route53-module"><span class="std std-ref">amazon.aws.route53</span></a> – add or delete entries in Amazons Route 53 DNS service</p></li>
 <li><p><a class="reference internal" href="amazon/aws/route53_health_check_module.html#ansible-collections-amazon-aws-route53-health-check-module"><span class="std std-ref">amazon.aws.route53_health_check</span></a> – Manage health checks in Amazons Route 53 DNS service</p></li>
 <li><p><a class="reference internal" href="amazon/aws/route53_info_module.html#ansible-collections-amazon-aws-route53-info-module"><span class="std std-ref">amazon.aws.route53_info</span></a> – Retrieves Route 53 details using AWS methods</p></li>
+<li><p><a class="reference internal" href="amazon/aws/route53_ksk_module.html#ansible-collections-amazon-aws-route53-ksk-module"><span class="std std-ref">amazon.aws.route53_ksk</span></a> – Manages a key-signing key (KSK)</p></li>
 <li><p><a class="reference internal" href="amazon/aws/route53_zone_module.html#ansible-collections-amazon-aws-route53-zone-module"><span class="std std-ref">amazon.aws.route53_zone</span></a> – add or delete Route 53 zones</p></li>
 <li><p><a class="reference internal" href="amazon/aws/s3_bucket_module.html#ansible-collections-amazon-aws-s3-bucket-module"><span class="std std-ref">amazon.aws.s3_bucket</span></a> – Manage S3 buckets in AWS, DigitalOcean, Ceph, Walrus, FakeS3 and StorageGRID</p></li>
 <li><p><a class="reference internal" href="amazon/aws/s3_bucket_info_module.html#ansible-collections-amazon-aws-s3-bucket-info-module"><span class="std std-ref">amazon.aws.s3_bucket_info</span></a> – Lists S3 buckets in AWS</p></li>

softwarefactory-project-zuul · 2024-12-04T17:15:21Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/79429715ab5e4dcba71aaf3aff031954

✔️ ansible-galaxy-importer SUCCESS in 11m 19s
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-splitter SUCCESS in 4m 13s
❌ integration-amazon.aws-1 FAILURE in 6m 34s
❌ integration-amazon.aws-2 FAILURE in 6m 52s
Skipped 42 jobs

softwarefactory-project-zuul · 2024-12-04T17:52:55Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4cc1e1d91be7478d859b97e7d14cc02d

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 10m 33s
✔️ ansible-test-splitter SUCCESS in 4m 15s
❌ integration-amazon.aws-1 FAILURE in 6m 40s
❌ integration-amazon.aws-2 FAILURE in 6m 25s
Skipped 42 jobs

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-04T18:20:21Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0efaa045d96441918a42deb8012c04a8

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-splitter SUCCESS in 4m 19s
❌ integration-amazon.aws-1 FAILURE in 5m 10s
❌ integration-amazon.aws-2 FAILURE in 6m 08s
Skipped 42 jobs

softwarefactory-project-zuul · 2024-12-05T14:37:02Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/effdf874583a4de29518bc70b754240f

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
❌ build-ansible-collection FAILURE in 4m 45s
✔️ ansible-test-splitter SUCCESS in 4m 36s
⚠️ integration-amazon.aws-1 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-2 SKIPPED Skipped due to failed job build-ansible-collection
Skipped 42 jobs

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-05T15:27:13Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8282ac126a75468682d65057091b2ad1

✔️ ansible-galaxy-importer SUCCESS in 3m 22s
✔️ build-ansible-collection SUCCESS in 10m 25s
✔️ ansible-test-splitter SUCCESS in 4m 24s
❌ integration-amazon.aws-1 FAILURE in 5m 47s
❌ integration-amazon.aws-2 FAILURE in 5m 15s
Skipped 42 jobs

alinabuzachis · 2024-12-06T16:42:34Z

recheck

softwarefactory-project-zuul · 2024-12-06T17:05:56Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a80cf260eba94211a78f0fa4f959467a

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 10m 34s
✔️ ansible-test-splitter SUCCESS in 5m 11s
❌ integration-amazon.aws-1 FAILURE in 9m 00s
❌ integration-amazon.aws-2 FAILURE in 7m 16s
Skipped 42 jobs

softwarefactory-project-zuul · 2024-12-08T11:39:39Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2eba44b0d7b94bcdaf6f2eb30042b699

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-splitter SUCCESS in 3m 56s
❌ integration-amazon.aws-1 FAILURE in 8m 18s
❌ integration-amazon.aws-2 FAILURE in 6m 19s
Skipped 42 jobs

softwarefactory-project-zuul · 2024-12-08T13:36:17Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/398e320247fa49898499ca7444bdaa76

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 10m 16s
✔️ ansible-test-splitter SUCCESS in 3m 50s
✔️ integration-amazon.aws-1 SUCCESS in 8m 50s
❌ integration-amazon.aws-2 FAILURE in 5m 42s
Skipped 42 jobs

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-09T11:35:17Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cac7a767e00d488f9ec6f5ddebe6ccfb

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 11m 18s
✔️ ansible-test-splitter SUCCESS in 4m 03s
✔️ integration-amazon.aws-1 SUCCESS in 10m 33s
✔️ integration-amazon.aws-2 SUCCESS in 7m 18s
Skipped 42 jobs

GomathiselviS · 2024-12-10T17:42:59Z

I would recommend creating a separate PR to add the new module for better clarity and easier review, rather than combining it with the addition of DNSSEC signing functionality.

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-11T10:53:10Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2b62c63a9b7644008f384bebf50c32a1

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 3m 59s
✔️ integration-amazon.aws-1 SUCCESS in 6m 34s
Skipped 43 jobs

plugins/modules/route53_ksk.py

softwarefactory-project-zuul · 2024-12-11T16:35:15Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1e207cda5a334a8cbd4a0fd2e1db88d1

✔️ ansible-galaxy-importer SUCCESS in 5m 20s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 4m 00s
✔️ integration-amazon.aws-1 SUCCESS in 8m 22s
Skipped 43 jobs

plugins/modules/route53_ksk.py

GomathiselviS · 2024-12-11T16:14:29Z

plugins/modules/route53_ksk.py

+  amazon.aws.route53_ksk:
+    name: "{{ resource_prefix }}-ksk"
+    hosted_zone_id: "{{ _hosted_zone.zone_id }}"
+    status: "INACTIVE"


Is status needed when we delete?

No it is not. However the module was saying that the user need to deactivate the KSK before deleting. I changed the behaviour and not it deactivates by default when the KSK need to be deleted.

GomathiselviS · 2024-12-11T16:20:22Z

plugins/modules/route53_ksk.py

+            if module.check_mode:
+                module.exit_json(
+                    changed=changed,
+                    msg=f"Would have updated the Key Signing Key status to {status} if not in check_mode.",


Can we return the changed dict (would have changed if not check_mode = true) as well?

GomathiselviS · 2024-12-11T16:21:15Z

plugins/modules/route53_ksk.py

+    else:
+        changed = True
+        if module.check_mode:
+            module.exit_json(changed=changed, msg="Would have created the Key Signing Key if not in check_mode.")


Can we return the changed dict (would have changed if not check_mode = true) as well?

Sorry but I don't understand what you mean. Can you please elaborate? changed is a boolean.

Apologies for the confusion in my previous statement. What I meant was: in addition to the 'changed' status, do you think it's possible to also return the "response/return dictionary," even if no changes are made to the resource? By definition, any module designed to support 'check mode' reports what changes would have been made without actually applying them. However, this approach is not followed by our cloud modules. I was wondering if we could start implementing this behavior in new modules and then work on modifying the existing ones later.

No worries, understood, done!

GomathiselviS · 2024-12-11T16:26:38Z

plugins/modules/route53_ksk.py

+        if module.check_mode:
+            module.exit_json(changed=changed, msg="Would have deleted the Key Signing Key if not in check_mode.")
+
+        if module.params.get("status") == "INACTIVE":


Is it possible for a condition to have state = "delete" and status = "ACTIVE"? I'm not sure if such a scenario can exist. Do we need this condition? We can ignore status for deletion. I think we should deactivate the key signing key before deleting in any case.

This situation was already handled because there was a note in the description asking the user to deactivate the key before deleting it. However, since it is not possible to delete a key without first deactivating it, eliminating an additional step or the need to specify the status: INACTIVE, I handled deactivation by default when the user wants to delete it.

plugins/modules/route53_ksk.py

tests/integration/targets/route53_ksk/tasks/main.yml

GomathiselviS · 2024-12-11T16:37:39Z

tests/integration/targets/route53_ksk/tasks/main.yml

+      amazon.aws.route53_ksk:
+        name: "{{ resource_prefix }}-ksk"
+        hosted_zone_id: "{{ _hosted_zone.zone_id }}"
+        status: "INACTIVE"


I am not sure about "status: INACTIVE" for deletion.

status: "INACTIVE" is not for deletion. state: absent is for deletion. status: "INACTIVE" deactivate the ksk.

Do we need the "status" parameter when the state is set to "absent/delete"? I'm trying to understand—if the goal is to delete the key, does its current status matter? Can we delete an ACTIVE key? If not, will it throw an error?

Are we going to delete the Key irrespective of its status?

No, we do not need it to delete a KSK. I updated the examples.

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-16T12:47:35Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2bd3670bcc974ef1afa8a09a31cda9d9

✔️ ansible-galaxy-importer SUCCESS in 6m 33s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-test-splitter SUCCESS in 3m 57s
✔️ integration-amazon.aws-1 SUCCESS in 7m 32s
Skipped 43 jobs

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-16T13:17:08Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/90b3c776705d4303ace7c443c710c106

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-splitter SUCCESS in 4m 07s
✔️ integration-amazon.aws-1 SUCCESS in 7m 38s
Skipped 43 jobs

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-16T16:19:06Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8b4f6ca8ea6941bbb7fc0c57654f59df

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 3m 51s
✔️ integration-amazon.aws-1 SUCCESS in 6m 30s
Skipped 43 jobs

GomathiselviS · 2024-12-16T16:54:19Z

plugins/modules/route53_ksk.py

+        if ksk["Status"] != status:
+            changed = True
+
+            if module.check_mode:


ksk["Status"] = status

Why is this needed?

For the same reason as the delete operation, when the resource is actually updated, the value of ksk["Status"] will be modified or set.

Okay, done although as mentioned below there is the informational message saying that the status would have been updated to ACTIVE/INACTIVE if it was not in control mode.
In general, I don't really know if we tweak the retuned result of the resource in check mode to reflect the desired updates though. If we do so, the msg probably becomes useless... but I don't know.

GomathiselviS · 2024-12-16T16:55:48Z

plugins/modules/route53_ksk.py

+        if module.check_mode:
+            module.exit_json(
+                changed=changed,
+                key_signing_key=camel_dict_to_snake_dict(ksk),


Suggested change

key_signing_key=camel_dict_to_snake_dict(ksk),

key_signing_key={},

I thought we could return the info about the resource that will be deleted.

From what I understand, check mode allows you to simulate the changes that would be made by the playbook or task. It shows you what would happen if the playbook were run in a live environment, but without making any actual changes to the actual resources. This is useful when you want to see the impact of the changes beforehand. Therefore, when a delete operation is performed, the return dictionary will be empty, which is the expected behavior here.

That is true, but since there is an informative message telling "Would have deleted if not in checked mode", I thought it will be useful if the actual resource is returned. However, I di not have a strong opinion about that so I updated as you suggested.

Thanks for doing this! I wanted the cloud modules to adhere to the definition of check mode that is used consistently across Ansible.

Signed-off-by: Alina Buzachis <[email protected]>

softwarefactory-project-zuul · 2024-12-17T15:23:36Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f0792371cca048fc95d0823c9e0de126

✔️ ansible-galaxy-importer SUCCESS in 3m 27s
✔️ build-ansible-collection SUCCESS in 10m 41s
✔️ ansible-test-splitter SUCCESS in 4m 12s
✔️ integration-amazon.aws-1 SUCCESS in 6m 55s
Skipped 43 jobs

alinabuzachis added 5 commits December 4, 2024 12:39

Add route53_ksk module

a606eff

Signed-off-by: Alina Buzachis <[email protected]>

Add support for dnssec

f958e86

Signed-off-by: Alina Buzachis <[email protected]>

Add changelog fragment

201ee31

Signed-off-by: Alina Buzachis <[email protected]>

Run black and isort

c66a5bd

Signed-off-by: Alina Buzachis <[email protected]>

Minor updates

bb0d46d

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the route53 branch from 8a29f2c to bb0d46d Compare December 4, 2024 16:52

alinabuzachis mentioned this pull request Dec 4, 2024

Allow Route53 DNSSEC Signing #1976

Open

1 task

Fix sanity

01aaf1e

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the route53 branch from 1ffb4d1 to 01aaf1e Compare December 4, 2024 18:03

alinabuzachis force-pushed the route53 branch from a94bf6d to d4acf2d Compare December 5, 2024 14:31

alinabuzachis force-pushed the route53 branch from d4acf2d to 9cdbb0a Compare December 5, 2024 14:40

Update

f0289dc

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the route53 branch from 9cdbb0a to f0289dc Compare December 5, 2024 14:54

alinabuzachis closed this Dec 6, 2024

alinabuzachis reopened this Dec 6, 2024

alinabuzachis closed this Dec 6, 2024

alinabuzachis reopened this Dec 6, 2024

alinabuzachis force-pushed the route53 branch from c5a5b30 to 3385733 Compare December 8, 2024 13:16

Fix

7af2ab3

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the route53 branch from 3385733 to 7af2ab3 Compare December 9, 2024 10:47

Split into two PRs

4201cbd

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the route53 branch from 011154e to 4201cbd Compare December 11, 2024 10:34

alinabuzachis changed the title ~~route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone; Add a new route53_ksk module~~ route53_ksk - new module Dec 11, 2024

alinabuzachis mentioned this pull request Dec 11, 2024

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

Open

alinabuzachis added the backport-9 label Dec 11, 2024

GomathiselviS reviewed Dec 11, 2024

View reviewed changes

plugins/modules/route53_ksk.py Show resolved Hide resolved

alinabuzachis added 2 commits December 11, 2024 17:14

Apply suggested changes

d75ea8b

Apply suggested changes

41e671a

alinabuzachis requested a review from GomathiselviS December 11, 2024 16:16

GomathiselviS reviewed Dec 11, 2024

View reviewed changes

alinabuzachis added 2 commits December 13, 2024 15:53

Modify upon review

ec06ecd

Signed-off-by: Alina Buzachis <[email protected]>

Modify upon review

a9f4022

Use info from find_ksk

af26f20

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis requested a review from GomathiselviS December 16, 2024 15:04

Return info in check_mode

03fb296

Signed-off-by: Alina Buzachis <[email protected]>

GomathiselviS requested changes Dec 16, 2024

View reviewed changes

Update

81fad8e

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis requested a review from GomathiselviS December 17, 2024 15:10

GomathiselviS approved these changes Dec 17, 2024

View reviewed changes

	key_signing_key=camel_dict_to_snake_dict(ksk),
	key_signing_key={},

route53_ksk - new module #2412

Are you sure you want to change the base?

route53_ksk - new module #2412

Conversation

alinabuzachis commented Dec 4, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Dec 4, 2024 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Dec 4, 2024

softwarefactory-project-zuul bot commented Dec 4, 2024

softwarefactory-project-zuul bot commented Dec 4, 2024

softwarefactory-project-zuul bot commented Dec 5, 2024

softwarefactory-project-zuul bot commented Dec 5, 2024

alinabuzachis commented Dec 6, 2024

softwarefactory-project-zuul bot commented Dec 6, 2024

softwarefactory-project-zuul bot commented Dec 8, 2024

softwarefactory-project-zuul bot commented Dec 8, 2024

softwarefactory-project-zuul bot commented Dec 9, 2024

GomathiselviS commented Dec 10, 2024

softwarefactory-project-zuul bot commented Dec 11, 2024

softwarefactory-project-zuul bot commented Dec 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GomathiselviS Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Dec 17, 2024

alinabuzachis commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

GomathiselviS Dec 13, 2024 •

edited

Loading