Skip to content

Commit

Permalink
Fix
Browse files Browse the repository at this point in the history
Signed-off-by: Alina Buzachis <[email protected]>
  • Loading branch information
alinabuzachis committed Dec 9, 2024
1 parent f0289dc commit 7af2ab3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
13 changes: 7 additions & 6 deletions plugins/modules/route53_zone.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
sample: "A1BCDEF2GHIJKL"
dnssec:
description: Information about DNSSEC for a specific hosted zone.
returned: when O(state=present)
returned: when O(state=present) and the hosted zone is public
version_added: 9.2.0
type: dict
contains:
Expand Down Expand Up @@ -400,12 +400,13 @@ def create(matching_zones):
zone_id = result.get("zone_id")

if zone_id:
# Enable/Disable DNSSEC
changed |= ensure_dnssec(client, module, zone_id)
if not private_zone:
# Enable/Disable DNSSEC
changed |= ensure_dnssec(client, module, zone_id)

# Update result with information about DNSSEC
result["dnssec"] = camel_dict_to_snake_dict(get_dnssec(client, module, zone_id))
del result["dnssec"]["response_metadata"]
# Update result with information about DNSSEC
result["dnssec"] = camel_dict_to_snake_dict(get_dnssec(client, module, zone_id))
del result["dnssec"]["response_metadata"]

# Handle Tags
if tags is not None:
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/targets/route53_ksk/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@
that:
- _ksk_request is successful
- _ksk_request.changed
- '"msg" in _ksk_request'
- '"Would have deleted the Key Signing Key if not in check_mode." in _ksk_request.msg'

- name: Delete the Key Signing Key request
amazon.aws.route53_ksk:
Expand All @@ -265,8 +267,6 @@
- _ksk_request is successful
- '"change_info" in _ksk_request'
- _ksk_request.changed
- '"msg" in _ksk_request'
- '"Would have deteled the Key Signing Key if not in check_mode." in _ksk_request.msg'

- name: Delete the Key Signing Key request (idempotency)
amazon.aws.route53_ksk:
Expand Down

0 comments on commit 7af2ab3

Please sign in to comment.