🐛 remove mac electron app code-signing

.github/workflows/electron-master.yml

@@ -51,8 +51,8 @@ jobs:
       - name: Build Electron
         run: ./bin/package-electron
         env:
-          CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
-          CSC_LINK: ${{ secrets.CSC_LINK }}
+          # CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
+          # CSC_LINK: ${{ secrets.CSC_LINK }}
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
       - name: Upload Build

bin/package-electron

@@ -38,7 +38,7 @@ yarn rebuild-electron
 
 yarn workspace loot-core build:node
 
-yarn workspace @actual-app/web build
+yarn workspace @actual-app/web build --mode=desktop
 
 yarn workspace desktop-electron update-client
 

packages/api/package.json

@@ -27,8 +27,8 @@
     "uuid": "^9.0.1"
   },
   "devDependencies": {
-    "@swc/core": "^1.3.105",
-    "@swc/jest": "^0.2.31",
+    "@swc/core": "^1.5.3",
+    "@swc/jest": "^0.2.36",
     "@types/jest": "^27.5.2",
     "@types/uuid": "^9.0.2",
     "jest": "^27.5.1",

packages/crdt/package.json

@@ -20,8 +20,8 @@
     "uuid": "^9.0.1"
   },
   "devDependencies": {
-    "@swc/core": "^1.3.105",
-    "@swc/jest": "^0.2.31",
+    "@swc/core": "^1.5.3",
+    "@swc/jest": "^0.2.36",
     "@types/jest": "^27.5.2",
     "@types/uuid": "^9.0.2",
     "jest": "^27.5.1",

packages/desktop-client/package.json

@@ -16,9 +16,9 @@
     "@react-stately/list": "^3.10.2",
     "@rollup/plugin-inject": "^5.0.5",
     "@svgr/cli": "^8.1.0",
-    "@swc/core": "^1.3.105",
-    "@swc/helpers": "^0.5.3",
-    "@swc/plugin-react-remove-properties": "^1.5.108",
+    "@swc/core": "^1.5.3",
+    "@swc/helpers": "^0.5.11",
+    "@swc/plugin-react-remove-properties": "^1.5.121",
     "@testing-library/react": "14.1.2",
     "@testing-library/user-event": "14.5.2",
     "@types/promise-retry": "^1.1.6",
@@ -30,7 +30,7 @@
     "@types/webpack-bundle-analyzer": "^4.6.3",
     "@use-gesture/react": "^10.3.0",
     "@vitejs/plugin-basic-ssl": "^1.1.0",
-    "@vitejs/plugin-react-swc": "^3.5.0",
+    "@vitejs/plugin-react-swc": "^3.6.0",
     "chokidar": "^3.5.3",
     "cross-env": "^7.0.3",
     "date-fns": "^2.30.0",
@@ -65,14 +65,14 @@
     "remark-gfm": "^3.0.1",
     "rollup-plugin-visualizer": "^5.12.0",
     "sass": "^1.70.0",
-    "swc-loader": "^0.2.3",
+    "swc-loader": "^0.2.6",
     "terser-webpack-plugin": "^5.3.10",
     "usehooks-ts": "^3.0.1",
     "uuid": "^9.0.1",
-    "vite": "^5.0.12",
-    "vite-plugin-pwa": "^0.19.0",
-    "vite-tsconfig-paths": "^4.3.1",
-    "vitest": "^1.2.1",
+    "vite": "^5.2.11",
+    "vite-plugin-pwa": "^0.20.0",
+    "vite-tsconfig-paths": "^4.3.2",
+    "vitest": "^1.6.0",
     "webpack-bundle-analyzer": "^4.10.1",
     "xml2js": "^0.6.2"
   },

packages/desktop-client/vite.config.mts

@@ -148,15 +148,18 @@ export default defineConfig(async ({ mode }) => {
       extensions: resolveExtensions,
     },
     plugins: [
-      VitePWA({
-        registerType: 'autoUpdate',
-        workbox: {
-          globPatterns: [
-            '**/*.{js,css,html,txt,wasm,sql,sqlite,ico,png,woff2,webmanifest}',
-          ],
-          ignoreURLParametersMatching: [/^v$/],
-        },
-      }),
+      // Macos electron (desktop) builds do not support PWA
+      mode === 'desktop'
+        ? undefined
+        : VitePWA({
+            registerType: 'autoUpdate',
+            workbox: {
+              globPatterns: [
+                '**/*.{js,css,html,txt,wasm,sql,sqlite,ico,png,woff2,webmanifest}',
+              ],
+              ignoreURLParametersMatching: [/^v$/],
+            },
+          }),
       injectShims(),
       addWatchers(),
       react({

packages/loot-core/package.json

@@ -40,9 +40,9 @@
   "devDependencies": {
     "@actual-app/api": "*",
     "@actual-app/crdt": "*",
-    "@swc/core": "^1.3.105",
-    "@swc/helpers": "^0.5.3",
-    "@swc/jest": "^0.2.31",
+    "@swc/core": "^1.5.3",
+    "@swc/helpers": "^0.5.11",
+    "@swc/jest": "^0.2.36",
     "@types/adm-zip": "^0.5.0",
     "@types/better-sqlite3": "^7.6.8",
     "@types/jest": "^27.5.2",
@@ -69,7 +69,7 @@
     "snapshot-diff": "^0.10.0",
     "source-map": "^0.7.4",
     "stream-browserify": "^3.0.0",
-    "swc-loader": "^0.2.3",
+    "swc-loader": "^0.2.6",
     "terser-webpack-plugin": "^5.3.10",
     "ts-node": "^10.9.2",
     "typescript": "^5.0.2",

upcoming-release-notes/2715.md

@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Desktop: remove code signing for Mac version